Falha no oneboxing da CNN

tgxworld · Maio 8, 2024, 5:33am

Isso é corrigido por

github.com/discourse/discourse

FIX: Attempt to onebox even if response body exceeds `max_download_kb`

main ← fix_dont_throw_away_response_body_when_max_download_exceeded

opened 05:28AM - 08 May 24 UTC

tgxworld

+45 -4

In 95a82d608d6377faf68a0e2c5d9640b043557852, we lowered the default for `Onebox….options.max_download_kb` from 10mb to 2mb for security hardening purposes. However, this resulted in multiple bug reports where seemingly nomral URLs stopped being oneboxed. It turns out that lowering `Onebox.options.max_download_kb` resulted in `Onebox::Helpers::DownloadTooLarge` being raised more often for more URLs in `Onebox::Helpers.fetch_response` which `Onebox::Helpers.fetch_html_doc` relies on. When `Onebox::Helpers::DownloadTooLarge` is raised in `Onebox::Helpers.fetch_response`, we throw away whatever response body which we have already downloaded at that point. This is not ideal because Nokogiri can parse incomplete HTML documents and there is a really high chance that the incomplete HTML document contains the information which we need for generating a reasonable onebox. Therefore, this commit updates `Onebox::Helpers.fetch_html_doc` to not throw away the response body when the size of the response body exceeds `Onebox.options.max_download_size`. Instead, we just take whatever we have and get Nokogiri to parse it.

Localmente, as URLs “problemáticas” relatadas neste tópico não exibem mais um erro quando tentamos fazer onebox.

Tópico		Respostas	Visualizações
Oneboxing large images fails with no visual cue Bug onebox	47	1547	4 de Maio de 2023
Onebox links result in large image downloads Feature	2	473	14 de Dezembro de 2022
Can't override size of image oneboxes Feature	3	805	18 de Junho de 2017
Onebox issue with a specific site Support onebox	14	1624	2 de Março de 2019
Onebox settings being ignored on edits Support	4	559	24 de Março de 2022

Falha no oneboxing da CNN

Tópicos relacionados