作曲家按钮盛会

denvergeeks · 2026 年1 月 21 日 04:34

我在我的 GitHub 仓库 GitHub - denvergeeks/DiscourseComposerButtonBonanza 中克隆了这个 TC，并应用了针对这些错误的修复 [因为似乎无法访问 Codeberg.org 服务进行分叉]。

这是我的更改的提交日志：

github.com/denvergeeks/DiscourseComposerButtonBonanza

Fix discourse.static-viewport-initialization by deferring composer button layout filtering to render time

committed 09:18PM - 27 Nov 25 UTC

denvergeeks

+0 -1

This change refactors the ComposerButtonBonanza theme component initializer to c…omply with the discourse.static-viewport-initialization deprecation warning, while preserving the existing behavior of custom composer buttons. Previously, the theme accessed site.desktopView (and implicitly site.mobileView) during static initialization when parsing the layout setting. Discourse now considers this access pattern unsafe because viewport state can change after initialization (for example, due to window resize or device rotation). Accessing viewport-dependent properties at that time can lead to inconsistent behavior and triggers the deprecation warning. This commit addresses the issue by making layout parsing view-agnostic and deferring all mobile/desktop decisions to a runtime callback that executes during composer toolbar creation. Key changes: Stop accessing site.desktopView during initialization: Removed the lookup of the site service and any mobile/desktop checks from the layout parsing path. parseLayout no longer inspects viewport state and does not depend on site.mobileView or site.desktopView. Refactor parseLayout to return an abstract, view-agnostic structure: parseLayoutEntry remains responsible for interpreting each layout entry and determining allowDesktop / allowMobile flags based on the X/M/D prefix. parseLayout now: Validates that each referenced button exists in BUTTONS. Populates TOGGLE_GROUPS based on the optional toggle-group name. Stores toolbar entries as objects of the form: { section, buttonSpec, allowDesktop, allowMobile } Stores gear-menu entries as: { buttonSpec, allowDesktop, allowMobile } No viewport-dependent filtering is performed inside parseLayout; it only builds an abstract representation of the desired layout. Defer viewport-dependent filtering to api.onToolbarCreate: The initializer still: Builds the BUTTONS lookup map from settings.buttons. Locates any translation overrides for the current locale from settings.translations. Initializes TOGGLE_GROUPS and calls parseLayout once at initialization time. Sets up the i18nProperties container under I18n.translations[...]js.composer[CBBKEY]. A single api.onToolbarCreate callback is now responsible for: Looking up the site service at render time. Computing isDesktop from site.desktopView in a context that is safe and supported by core. Iterating over layout.toolbar and adding only those toolbar buttons whose allowDesktop / allowMobile flags match the current view. Iterating over layout.gearmenu and registering gear-menu popup options under the same view-dependent rules. Maintain toggle-group and i18n behavior: The logic for constructing toggle groups (TOGGLE_GROUPS) remains in parseLayout, so groups are still configured once based on the parsed layout. The i18n plumbing via i18nProperties, setI18nProperty, and applyTranslation is unchanged; button titles, labels, example text, and hover text still use the same translation keys and override mechanism. Impact and rationale: The deprecation warning is resolved because site.desktopView / site.mobileView are now read only inside api.onToolbarCreate, which is invoked as part of composer toolbar rendering rather than at static initialization time. Layout semantics for mobile vs. desktop remain the same: X, M, and D prefixes in the layout string still control whether each button can appear on desktop, mobile, both, or never. The only difference is when the filtering occurs (during toolbar creation instead of during layout parsing). Gear-menu and toolbar buttons are still defined from the same layout configuration, and their actions, icons, and toggle behavior are preserved. In summary, this commit cleans up the viewport access pattern in api-initializer.js to align with modern Discourse expectations, while keeping the functional behavior of ComposerButtonBonanza’s custom buttons consistent across desktop and mobile views.

话题		回复	浏览量
MD Composer extras Theme component	70	8752	2025 年7 月 8 日
Help us test the rewritten Composer Feature feedback	145	23212	2016 年10 月 21 日
Test our new composer! Announcements composer	129	3942	2025 年7 月 10 日
Formatting toolbar Plugin	183	33001	2026 年1 月 28 日
Fast Highlight Dev	49	2361	2023 年9 月 30 日

作曲家按钮盛会

相关话题