Core discourse-reactions bug with +1 reaction hover popover

zogstrip · May 21, 2026, 11:12am

Thanks for the report @PortChange This will be fixed by

github.com/discourse/discourse

FIX: Properly URL-encode reaction value when fetching reaction users (#40218)

main ← fix-reactions-users-popup-url-encoding

merged 01:54PM - 21 May 26 UTC

ZogStriP

+26 -4

The `findReactionUsers` model method built its query string via plain template-l…iteral concatenation, e.g. `?reaction_value=${value}`. For reactions whose value contains URL-reserved characters — most notably the default `+1` (thumbs-up) — this produced `?reaction_value=+1`, which Rack decodes as `reaction_value=" 1"`. The controller then queried for that mangled value, returned an empty `reaction_users` array, and the hover tooltip on the small emoji in the post reactions counter rendered its loading spinner indefinitely (the `{{#each ... else}}` branch fires when the users collection stays undefined). Switch to passing the value through ajax's `data:` option so jQuery serializes it via `$.param` (which uses `encodeURIComponent`). This matches what the sibling `fetchReactionsUsersList` (new menu) already does and means the request reaches the backend as `%2B1`. While here, update the `PostReactionsList` page object to use `[id="..."]` instead of the bare `#id` CSS selector, so it tolerates reaction values that contain characters disallowed in unescaped ID selectors. This unlocks a regression spec that hovers over a `+1` reaction and verifies the user list populates. Ref - t/184216

Topic		Replies	Views
Show usernames in Reacted popover UX reactions	4	449	September 30, 2023
Use of +1 for discourse_reactions_like_icon disables reactions button Support reactions	3	477	September 11, 2023
Inconsistent tooltips on Reactions UX reactions	0	42	August 2, 2024
Reactions plugin causing "Something went wrong" error when confirming emoji Bug	2	508	January 24, 2022
Reactions sometimes not displayed when like count is missing Bug reactions	4	163	January 9, 2026

Core discourse-reactions bug with +1 reaction hover popover

Related topics