# Cursor is overriden when upload finishes
**URL:** https://meta.discourse.org/t/cursor-is-overriden-when-upload-finishes/54892
**Category:** Feature
**Created:** [28 Dezembro , 2016 17:55 UTC](https://meta.discourse.org/t/cursor-is-overriden-when-upload-finishes/54892 "2016-12-28T17:55:27Z")
**Posts on this page:** 9
**Page:** 1
### Author:  [@claas](https://meta.discourse.org/u/claas)
#### Post date: [28 Dezembro , 2016 17:55 UTC](https://meta.discourse.org/t/cursor-is-overriden-when-upload-finishes/54892/1 "2016-12-28T17:55:27Z")
1. I’m writing a post and upload a photo (which is large or which takes long due to slow internet connection)…
2. While it uploads, I continue writing…
3. Once the download finishes, my cursor lands behind the image!
Expectation: The cursor should be preserved.
---
### Author:  [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [28 Dezembro , 2016 18:00 UTC](https://meta.discourse.org/t/cursor-is-overriden-when-upload-finishes/54892/2 "2016-12-28T18:00:28Z")
Isn’t this expected since the text has to be replaced when the upload is complete? That’s not a bug.
---
### Author:  [@claas](https://meta.discourse.org/u/claas)
#### Post date: [28 Dezembro , 2016 18:05 UTC](https://meta.discourse.org/t/cursor-is-overriden-when-upload-finishes/54892/3 "2016-12-28T18:05:31Z")
> [@codinghorror](#):
>
> Isn’t this expected since the text has to be replaced when the upload is complete? That’s not a bug.
It’s certainly a side effect of replacing the text, but it’s also not so nice for the user. I think we could save the cursor position before we replace the text and restore it thereafter.
---
### Author:  [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [28 Dezembro , 2016 18:16 UTC](https://meta.discourse.org/t/cursor-is-overriden-when-upload-finishes/54892/4 "2016-12-28T18:16:42Z")
Still if you are actively typing when that happens weird stuff is gonna happen.
---
### Author:  [@claas](https://meta.discourse.org/u/claas)
#### Post date: [28 Dezembro , 2016 18:34 UTC](https://meta.discourse.org/t/cursor-is-overriden-when-upload-finishes/54892/5 "2016-12-28T18:34:41Z")
> [@codinghorror](#):
>
> Still if you are actively typing when that happens weird stuff is gonna happen.
Just tried it out a couple of times and all I could reproduce is that, if I type very fast, one character is omitted. Is this what you refer to as “weird stuff”?
I would say though that these are two phenomena that add up and getting rid of each of them is desirable, or isn’t it?
---
### Author:  [@claas](https://meta.discourse.org/u/claas)
#### Post date: [28 Dezembro , 2016 20:28 UTC](https://meta.discourse.org/t/cursor-is-overriden-when-upload-finishes/54892/6 "2016-12-28T20:28:57Z")
So the upload placeholder replacement is triggered in `composer-editor.js.es6` [here](https://github.com/discourse/discourse/blob/52cd9972bb832a32a51c014ad6096a1bd01ecdcd/app/assets/javascripts/discourse/components/composer-editor.js.es6#L211) (on cancel) and [here](https://github.com/discourse/discourse/blob/52cd9972bb832a32a51c014ad6096a1bd01ecdcd/app/assets/javascripts/discourse/components/composer-editor.js.es6#L265) (on success) and handled by `d-editor.js.es6` [here](https://github.com/discourse/discourse/blob/7515f4eec20abb5c869434c2ccb2541127628969/app/assets/javascripts/discourse/components/d-editor.js.es6#L249) or here respectively:
>
This would be the place where we _could_ preserve the cursor position, given that we replace the text in a _synchronous_ fashion (\*):
- If the cursor position is before the needle, preserve it.
- If the cursor position is in the needle, set it to the end of the replacement.
- If the cursor position is behind the needle, add `(replacement.length - needle.length)` to the cursor.
(\*) = …but `_setSelection` (which is used by `_replaceText` to _explicitly_ set the cursor behind the image) works [in an asynchronous fashion](https://github.com/discourse/discourse/blob/7515f4eec20abb5c869434c2ccb2541127628969/app/assets/javascripts/discourse/components/d-editor.js.es6#L417-L429).
---
### Author:  [@claas](https://meta.discourse.org/u/claas)
#### Post date: [28 Dezembro , 2016 21:28 UTC](https://meta.discourse.org/t/cursor-is-overriden-when-upload-finishes/54892/7 "2016-12-28T21:28:08Z")
Just in case you change your mind and give it a try (works for me):
[https://github.com/discourse/discourse/pull/4630](https://github.com/discourse/discourse/pull/4630)
PS: Last PR for some time, as vacation ends for me today.
---
### Author:  [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [28 Dezembro , 2016 22:26 UTC](https://meta.discourse.org/t/cursor-is-overriden-when-upload-finishes/54892/8 "2016-12-28T22:26:34Z")
Sure if @zogstrip likes it we can pull it in.
---
### Author:  [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [28 Dezembro , 2016 22:27 UTC](https://meta.discourse.org/t/cursor-is-overriden-when-upload-finishes/54892/9 "2016-12-28T22:27:10Z")
❤ it. Just need to fix the tests and I’ll merge it 😉