There have been multiple bug reports for the events plugin in the last two days that all seem to be type-casting issues with custom fields. The events plugin hasn’t been substantively updated in a few months. [תמונה] Events Plugin calendar Plugin Is the bellow error related to this plugin? (also posted here) a user created a topic by copy pasting some content from a facebook page; this has crashed the topic iteslf, the category and his activities page. (the rest of the topics and categories of the site remained accessible) I managed to destroy the topic from the console and everything went back to normal for the user and category. Is this error related to the mentioned plugin “discourse-events”? here follows the errors: info: NoMet… The plugin.rb file casts event_start as an integer: Topic.register_custom_field_type('event_start', :integer) The error is being thrown here: def has_event? self.custom_fields['event_start']&.nonzero? end The error itself follows this format: NoMethodError (undefined method `nonzero?' for [1563127206, 1563127206]:Array) As far as I understand register_custom_field_type it should ensure that the custom_field always returns as the defined type (perhaps I’m misunderstanding it). Looking at the has_custom_fields.rb concern, there have been a few changes in the past week that could have affected this, in particular https://github.com/discourse/discourse/commit/72bac61c90044407f7a2029b15f6ac043a8bccf0#diff-712e064741bd664591e6392a52eb409e @eviltrout Any thoughts on this?

In case this is indeed the bug causing problems, here I explain the consequences (it may make your site unusable): [תמונה] Events Plugin calendar Plugin This patch seems to work! I can tell that the difference between having this patch or not for us meant having a broken site or a(n apparently) fully functional one. These were the effects of the bug: Discourse not rendering to anonymous users beyond the header (totally unusable site). For registered users, probably non-cached content (i.e. Latest lists) wouldn’t render, and the rest was a hit or miss. Strangely enough, from three admins two would lose access to the web UI completely while a t…

[תמונה] angus: The error itself follows this format: NoMethodError (undefined method `nonzero?' for [1563127206, 1563127206]:Array) This was a known bug with custom fields. In very specific conditions, it would save the value multiple times, thus creating an Array, when you only want an Integer. You can fix this by making sure there’s only 1 row per custom field in the database.

[תמונה] zogstrip: This was a known bug with custom fields. Yes, it’s cropped up a few times in the past. This latest rash seems to coincide with recent work on the has_custom_fields.rb concern, so there may be something to review there. This doesn’t fix it, but helps to address it if it arises: https://github.com/discourse/discourse/pull/7886

[תמונה] angus: NoMethodError (undefined method `nonzero?’ for [1563127206, 1563127206]:Array) My general recommendation here is that as a plugin author you should always add indexes in a migration to properly enforce the constraint. In fact majority of plugins we right these days avoid custom fields unless absolutely needed and prefer using custom tables which are far easier to reason about. In this specific case you want an index of: create unique index idxStartEvent on topic_custom_fields(topic_id) where name = 'start_event' Not sure what else really we need to do in core here, we have considered a revamp of custom fields but are somewhat worried about it. One thing I am considering is simply dropping array support from custom fields cause they are just causing enormous amounts of issues over the years.

[תמונה] zogstrip: In very specific conditions, it would save the value multiple times, thus creating an Array, when you only want an Integer. Sorry for bumping this up but one of the conditions is when you use a symbol index i.e. custom_fields[:hello] while updating the existing value, it added another field instead of updating and hence the giving an array. This might be the only condition IMO. This should fix the caused side-effect most certainly. https://github.com/discourse/discourse/pull/10486

Custom field casting affected by recent update?

מפתח

icaria36 12 ביולי,‏ 2019,‏ 9:56am 2

In case this is indeed the bug causing problems, here I explain the consequences (it may make your site unusable):

נושא		תגובות	צפיות
How to add custom fields to models Extras pavilion	48	9778	30 בספטמבר,‏ 2025
Db:migrate fails on discourse-calendar (stable branches) Self-hosting	2	815	6 בספטמבר,‏ 2019
Potential bug where data in custom fields is cleared if certain fields change Bug events , fixed	1	147	14 באוגוסט,‏ 2026
Db:migrate fails on discourse-calendar Self-hosting	3	1525	1 באוגוסט,‏ 2019
Are custom_fields on posts/topics available via the API? Development	7	3562	24 באוקטובר,‏ 2018

Custom field casting affected by recent update?

נושאים קשורים