Deleted post sent as notification for notify of all posts user


(James Milligan) #1

If a post has been deleted on the forum, a notification is still sent out for it to users which reads, rather confusingly:

(post withdrawn by author, will be automatically deleted in 24 hours unless flagged)

This generated quite a few replies asking what it all meant.

Can this be fixed so that deleted posts don’t get sent out as notifications?


(Jeff Atwood) #2

I thought we had protections in place for this @eviltrout? Can you check Monday and confirm?


(Robin Ward) #3

We definitely should have that check but I’ll confirm.


(Robin Ward) #4

When you say notification, do you mean email right?

Because I double checked the code and test suite and we shouldn’t be sending an email with that content. Are you perhaps seeing it elsewhere? Maybe if you can give detailed steps to reproduce we could help!

edit: @riking figured out that there’s a possible code path where mailing list mode is on that I missed. Fixing.


(Robin Ward) #5

Okay, here’s a fix for the mailing list mode. Bonus: Includes tests, which previously did not exist for this feature:

https://github.com/discourse/discourse/commit/17b6d3a2fe011c19b7283559d9d9444d519f5c88


(Jeff Atwood) #6