As to using scope here, I think it makes sense to make the change to Discourse provided scope is well supported.
---
### Author:  [@Jacky\_Cheng](https://meta.discourse.org/u/Jacky_Cheng)
#### Post date: [April 30, 2019, 4:20am UTC](https://meta.discourse.org/t/disable-service-worker-initializer/116392/5 "2019-04-30T04:20:50Z")
```
if (
registration.active &&
!registration.active.scriptURL.includes(
Discourse.ServiceWorkerURL
)
) {
registration.unregister();
}
```
shouldn’t this if condition to be this one to only unregister Discourse ServiceWorker ?
```
if (
registration.active &&
registration.active.scriptURL.includes(
Discourse.ServiceWorkerURL
)
) {
registration.unregister();
}
```
---
### Author:  [@sam](https://meta.discourse.org/u/sam)
#### Post date: [April 30, 2019, 5:03am UTC](https://meta.discourse.org/t/disable-service-worker-initializer/116392/6 "2019-04-30T05:03:49Z")
Yeah reading through this we are being mega aggressive with de-registrations due to historic moves of our url.
@tgxworld any thoughts here? should we be more accurate here.
---
### Author:  [@Jacky\_Cheng](https://meta.discourse.org/u/Jacky_Cheng)
#### Post date: [May 2, 2019, 9:34am UTC](https://meta.discourse.org/t/disable-service-worker-initializer/116392/7 "2019-05-02T09:34:05Z")
Could you provide some workaround now ?
I saw some tutorials about plugins?
Can I write a plugin to overwrite the initialize/js file ?
---
### Author:  [@sam](https://meta.discourse.org/u/sam)
#### Post date: [May 3, 2019, 12:28am UTC](https://meta.discourse.org/t/disable-service-worker-initializer/116392/8 "2019-05-03T00:28:08Z")
We need to fix the file so we only de-register our stuff, maybe look for a specific string.
@tgxworld can you add this to your list, should be an easy change.
---
### Author:  [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [May 7, 2019, 5:12am UTC](https://meta.discourse.org/t/disable-service-worker-initializer/116392/10 "2019-05-07T05:12:53Z")
Looks like registration didn’t consider subfolder support as well. Fixed in
[https://github.com/discourse/discourse/commit/abbc639e0d362ae90b52c8b5c6922d9e610777f8](https://github.com/discourse/discourse/commit/abbc639e0d362ae90b52c8b5c6922d9e610777f8)
@Jacky_Cheng Let me know if this fixes it for you 🙂
---
### Author:  [@Jacky\_Cheng](https://meta.discourse.org/u/Jacky_Cheng)
#### Post date: [May 7, 2019, 6:02am UTC](https://meta.discourse.org/t/disable-service-worker-initializer/116392/11 "2019-05-07T06:02:46Z")
Thanks for your reply.
I forgot to bring up that Safari now can support service-worker.
So
`const isApple = !!navigator.platform.match(/(Mac|iPhone|iPod|iPad)/i);`
should be remove Mac condition in my opinion.
Also in [discourse/app/assets/javascripts/discourse/initializers/register-service-worker.js.es6 at abbc639e0d362ae90b52c8b5c6922d9e610777f8 · discourse/discourse · GitHub](https://github.com/discourse/discourse/tree/abbc639e0d362ae90b52c8b5c6922d9e610777f8/app/assets/javascripts/discourse/initializers/register-service-worker.js.es6) the else condition would also unregister service worker, it should add the url condition.
---
### Author:  [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [May 7, 2019, 6:14am UTC](https://meta.discourse.org/t/disable-service-worker-initializer/116392/12 "2019-05-07T06:14:11Z")
> [@Jacky\_Cheng](#):
>
> I forgot to bring up that Safari now can support service-worker.
Yup we know but Discourse is not ready to support Service workers on Safari yet because it has been problematic for us so far.
> [@Jacky\_Cheng](#):
>
> the else condition would also unregister service worker, it should add the url condition.
It does consider the URL condition because I extracted both of the unregister function calls into a common function.
---
### Author:  [@Jacky\_Cheng](https://meta.discourse.org/u/Jacky_Cheng)
#### Post date: [May 7, 2019, 6:20am UTC](https://meta.discourse.org/t/disable-service-worker-initializer/116392/13 "2019-05-07T06:20:58Z")
> [@tgxworld](#):
>
> It does consider the URL condition because I extracted both of the unregister function calls into a common function.
Oh I see.
I think this would fix my problem.
Thanks a lot.
---
### Author:  [@robbiet480](https://meta.discourse.org/u/robbiet480)
#### Post date: [June 22, 2019, 5:32am UTC](https://meta.discourse.org/t/disable-service-worker-initializer/116392/14 "2019-06-22T05:32:28Z")
Just a FYI that I’ve [submitted a PR](https://github.com/discourse/discourse/pull/7792) to once again enable the service worker on Apple platforms so that push notifications start working as per my findings [here](https://meta.discourse.org/t/discourse-push-notifications-for-desktop/86941/52).