# Disabling Allow New Registrations still shows registration link and modal

**URL:** <https://meta.discourse.org/t/disabling-allow-new-registrations-still-shows-registration-link-and-modal/42660>\
**Category:** Bug\
**Created:** [4월 16, 2016, 6:19오후 UTC](https://meta.discourse.org/t/disabling-allow-new-registrations-still-shows-registration-link-and-modal/42660 "2016-04-16T18:19:27Z")\
**Posts on this page:** 6\
**Page:** 1

<div class="post-metadata">

**Author:** ![ron\_jeremy](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/ron_jeremy/32/56621_2.png) [@ron\_jeremy](https://meta.discourse.org/u/ron_jeremy)\
**Post date:** [4월 16, 2016, 6:19오후 UTC](https://meta.discourse.org/t/disabling-allow-new-registrations-still-shows-registration-link-and-modal/42660/1 "2016-04-16T18:19:27Z")

</div>

_Please feel free to move or delete this post if it is in fact not a bug_.

I noticed that if I **uncheck** `allow new registrations`the ‘Sign Up’ link is still visible in the header. Furthermore, the link opens the registration modal and allows one to fill in all the fields only to be prompted that **new registrations are currently not allowed** after all required info is submitted.

This is a bit of a piss-off if you’ve just gone through the hassle to enter all your registration info, don’t you think?

Wouldn’t it be better to simply remove the ‘Sign Up’ link (and disable the registration modal)? This is already enforced with the`invite only` setting, so it shouldn’t be difficult to implement.

Thoughts?

---

<div class="post-metadata">

**Author:** ![Mittineague](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/mittineague/32/114259_2.png) [@Mittineague](https://meta.discourse.org/u/Mittineague)\
**Post date:** [4월 16, 2016, 8:30오후 UTC](https://meta.discourse.org/t/disabling-allow-new-registrations-still-shows-registration-link-and-modal/42660/2 "2016-04-16T20:30:48Z")

</div>

> [@ron\_jeremy](#):
>
> Thoughts?

I don’t know as I’d call this a Bug instead of UX.

But I agree, I’d rather not be presented with an option to a process that can’t be completed, or know that it can’t be completed sooner rather than later.

As for how much work would be involved to implement the change, I have no idea.  
But I have learned that most often what the ignorant declare as “simple” or “easy” is often neither.

---

<div class="post-metadata">

**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\
**Post date:** [4월 16, 2016, 8:59오후 UTC](https://meta.discourse.org/t/disabling-allow-new-registrations-still-shows-registration-link-and-modal/42660/3 "2016-04-16T20:59:09Z")

</div>

Sure we can probably improve this, that is a bit of an emergency switch though – it turns off all signups, unconditionally, forever. @techapj can you have a look at doing something simple but better here? Do not want to spend a lot of time on it.

---

<div class="post-metadata">

**Author:** ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)\
**Post date:** [4월 17, 2016, 11:17오전 UTC](https://meta.discourse.org/t/disabling-allow-new-registrations-still-shows-registration-link-and-modal/42660/4 "2016-04-17T11:17:29Z")

</div>

> [@ron\_jeremy](#):
>
> I noticed that if I uncheck
> 
> `allow new registrations`
> 
> the ‘Sign Up’ link is still visible in the header.

I am not able to repro this.

In my local testing when I disabled `allow new registrations` setting, the ‘Sign Up’ button was hidden from site header. This is expected, as per this code:

[https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/controllers/application.js.es6#L9-L13](https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/controllers/application.js.es6#L9-L13)

Are you testing this on latest Discourse version?

---

<div class="post-metadata">

**Author:** ![ron\_jeremy](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/ron_jeremy/32/56621_2.png) [@ron\_jeremy](https://meta.discourse.org/u/ron_jeremy)\
**Post date:** [4월 17, 2016, 8:14오후 UTC](https://meta.discourse.org/t/disabling-allow-new-registrations-still-shows-registration-link-and-modal/42660/5 "2016-04-17T20:14:35Z")

</div>

Yeah, I have the latest. Well, it looks like this is no longer an issue because today I cannot repro it either. However, yesterday I could repro at will. Strange…

---

<div class="post-metadata">

**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\
**Post date:** [4월 17, 2016, 8:32오후 UTC](https://meta.discourse.org/t/disabling-allow-new-registrations-still-shows-registration-link-and-modal/42660/7 "2016-04-17T20:32:00Z")

</div>


