# Disallow setting 'enable\_sso' without SOMETHING in 'sso\_url'

**URL:** <https://meta.discourse.org/t/disallow-setting-enable-sso-without-something-in-sso-url/76607>\
**Category:** Bug\
**Created:** [2017年十二月22日 03:53 UTC](https://meta.discourse.org/t/disallow-setting-enable-sso-without-something-in-sso-url/76607 "2017-12-22T03:53:26Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![supermathie](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/supermathie/32/507518_2.png) [@supermathie](https://meta.discourse.org/u/supermathie)\
**Post date:** [2017年十二月22日 03:53 UTC](https://meta.discourse.org/t/disallow-setting-enable-sso-without-something-in-sso-url/76607/1 "2017-12-22T03:53:26Z")

</div>

We should not allow Discourse admins to wedge themselves into this corner (or at least give them a warning?) where:

```plaintext
SiteSetting.enable_sso == true
SiteSetting.sso_url == ""

```

---

<div class="post-metadata">

**Author:** ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)\
**Post date:** [2017年十二月22日 04:11 UTC](https://meta.discourse.org/t/disallow-setting-enable-sso-without-something-in-sso-url/76607/2 "2017-12-22T04:11:20Z")

</div>

Yes definitely can we add a validation here @techAPJ

---

<div class="post-metadata">

**Author:** ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)\
**Post date:** [2017年十二月23日 08:05 UTC](https://meta.discourse.org/t/disallow-setting-enable-sso-without-something-in-sso-url/76607/3 "2017-12-23T08:05:19Z")

</div>

Fixed via:

[https://github.com/discourse/discourse/commit/0514ac4ee2f7f383ba8ce7a33453fe0232af601a](https://github.com/discourse/discourse/commit/0514ac4ee2f7f383ba8ce7a33453fe0232af601a)

---

<div class="post-metadata">

**Author:** ![techAPJ](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/techapj/32/342990_2.png) [@techAPJ](https://meta.discourse.org/u/techAPJ)\
**Post date:** [2017年十二月24日 12:30 UTC](https://meta.discourse.org/t/disallow-setting-enable-sso-without-something-in-sso-url/76607/4 "2017-12-24T12:30:07Z")

</div>

This topic was automatically closed after 28 hours. New replies are no longer allowed.