Here’s the PR to support dark mode category logos:
[https://github.com/naidihr/discourse-category-headers/pull/21](https://github.com/naidihr/discourse-category-headers/pull/21)
---
> [@tknospdr](#):
>
> Minor request, can you make the ‘Read more’ link color the same as the rest of the text?
> …
> The rest of the text seems to auto select white or black based on the background color. Can you do that for the link too?
This bugged me a little too. A bit of custom CSS does the trick:
```plaintext
// let Category Headers Read More link use same color as summary text
.category-about-url a {
color: inherit;
}
```
---
My remaining wish for the “read more” link: show it only if more content actually exists. I have some long About category pages and some short ones, & I’d rather not offer a link to no added content.
(I have no idea if this is feasible. Might be a lot to ask of a TC.)
---
When the **full category description** is showing, I also encounter this on Theme Creator and on my dev instance. I’m looking into it. I suspect it’s because the route changes but the tracked variable does not.
UPDATE: I have added an expand/collapse functionality for category descriptions here. @nathank Also fixed the bug in:
[https://github.com/naidihr/discourse-category-headers/pull/22](https://github.com/naidihr/discourse-category-headers/pull/22)
With a little nudge from Ask Discourse for using `willDestroy` with the router service.
---
A late morning for me, actually 😉. I’ll look into whether your suggestion about checking if the description has any more text is possible. I also felt myself needing that during my testing.
---
> [@NateDhaliwal](#):
>
> UPDATE: I have added an expand/collapse functionality for category descriptions here
This is a fantastic addition! ❤
Just one small point of feedback: It might make sense to add a chevron icon to the top right corner or right edge of the category header to indicate expand/collapse functionality to the users. But it’s a great starter, and for now using an emoji in link text as an indicator does the job:
(Sidenote, maybe also add translations for the link text?
---
PR has been merged :git_merged: !
> [@jrgong](#):
>
> add a chevron icon to the top right corner or right edge of the category header to indicate expand/collapse functionality to the users
Got it 👍 . I’ll take a look.
---
Nate, the _read more/less_ functionality is excellent, thank you!
If there’s a way to condition that link on more text existing, that’d be great – but I could also just write longer descriptions 😆
I do see a couple issues you might not have had a chance to spot:
- category & tag links aren’t rendering their SVG icons
- the category image isn’t coming through so I’m getting the default site icon
> **(screenshot)**
>
> 
A little thing I’ve managed to work around: links in the About text weren’t inheriting the text color, like the _read more_ link mentioned [earlier](https://meta.discourse.org/t/discourse-category-headers-theme-component/148682/169). This CSS styles the text links without affecting category and tag links:
```css
// text link styling, to exclude category and tag links
.category-title-header .category-title-description
a:not([data-type="tag"], [data-type="category"]) {
color: inherit;
text-decoration: underline;
}
```
> **(screenshots)**
>
> 
> 
I’m really impressed with the updates, & hope my SVG & icon issues are just a simple fix.
---
> [@ToddZ](#):
>
> category & tag links aren’t rendering their SVG icons
Interesting. Do you know if this was there previously?
> [@ToddZ](#):
>
> the category image isn’t coming through so I’m getting the default site icon
I’ll take a look. I also encountered this. Try disabling the `show site logo` setting in the meantime, that seems to fix it.
> [@ToddZ](#):
>
> links in the About text weren’t inheriting the text color, like the _read more_ link mentioned [earlier](https://meta.discourse.org/t/discourse-category-headers-theme-component/148682/169).
Thanks. Was this the case previously and some change occurred?
---
> Try disabling the `show site logo` setting in the meantime, that seems to fix it.
That works - thanks! I should have experimented with more settings.
As to the SVG link icons and text link colors, I can’t say what they might’ve done before – I never had links in the short summary part of the About text, but now there are some in the expanded ‘read more’.
(I shared that link-color CSS in case it was helpful to you or anyone, but I know that kind of styling tweaking isn’t necessarily the component’s responsibility.)
---
Nate, any thoughts on the issue with placeholder category/link SVG icons?
 
I don’t know if there are differences in how they have to be coded in the header vs. in the topic, but what’s being output is quite different:
> **Category link comparison**
>
> Category link in header:
> 
>
> ```html
>
>
>
>
> Wild Speculations
>
>
> ```
>
> Category link in topic:
> 
>
> ```html
>
>
> Wild Speculations
>
>
> ```
and
> **Tag link comparison**
>
> Tag link in header:
> 
>
> ```html
>
>
>
>
> ai
>
>
> ```
>
> Tag link in topic:
> 
>
> ```html
>
>
> ai
>
>
> ```
---
I’ve been busy these few days (will get to it tomorrow). I suspect this is included in the category description. If you use the full description, does it still occur?
---
I appreciate that you’re volunteering your efforts, and I don’t mean to badger you. I Iooked into it to see if there’s something I could solve myself. (There’s not. 😳)
But yes, it still happens with `Show full category description` active.
---
I’ll try and see if there’s anything I can do. The last resort is to use some logic (which may be complicated) to adjust them based on colors (which may not account for icons). I’m open to suggestions if anyone has a better way.
@ToddZ If you look at [this example](https://meta.discourse.org/c/bug/1) of the official [Category Banners](https://meta.discourse.org/t/category-banners/86241) component (which I think Meta uses), it also has this problem.
---
> [@NateDhaliwal](#):
>
> the official [Category Banners](https://meta.discourse.org/t/category-banners/86241) component… also has this problem.
I see…! And someone mentions the problem:
> [@Category Banners](https://meta.discourse.org/t/category-banners/86241/234):
>
> This component works well with the category tag component but unfortunately is not compatible with the tag icon component. While tag icons function elsewhere on the site, they do not work in the description section. Is there a way to fix this?
I installed Category Banners to verify that category icons work – but they didn’t. Both category and tag icons get the placeholder, just as with Category Headers. And it’s the same regardless of the outlet chosen in the settings.
If there’s a way to just get them to process normally that’d be great, but I wouldn’t want you to resort to a complex workaround.
---
I just tested the compatibility with horizon theme. all in all it’s basically working, but the only issue is that the plugin outlet currently used by the category headers theme component is inside list-controls container on Horizon theme. Hence the whole category header stays sticky.
Suggested solution is to change the plugin outlet or add an option to choose a different plugin outlet outside list-controls container, e.g. `discovery-list-controls-above` outlet.
I can spin up a PR if you want @NateDhaliwal
---
I have submitted a PR for this theme component. I was a bit clumsy so it’s one PR with two different things 😭
- Feature: add a plugin outlet after the category title description
- Fix: the theme component did not use the S3 CDN for the background image
Could you have a look and merge please?
---
Looks good! I’ve gone ahead to merge it. (Also, apologies for not seeing it earlier)
[Previous page](https://meta.discourse.org/t/discourse-category-headers-theme-component/148682.md?page=8)
[Next page](https://meta.discourse.org/t/discourse-category-headers-theme-component/148682.md?page=10)