Discourse Category Headers theme component

Customization Theme component
188

I have a site using this component, and for some reason the logo pics aren’t loading when it’s active.
They load correctly in safe mode, so I know they are there.
If I turn off the feature to show the site small logo if category logo is not set, then they load correctly.
I’m not sure when exactly this broke, but it used to work correctly with this option turned on.
I like to leave it on as I have one category that does not have a logo set and I do want the site small logo displayed there.

Any help or advice greatly appreciated.

189

I have not changed the logic here for quite a while. Could you share your settings configuration for the component?

1 Like
190

2 Likes
191

That screenshot is my settings. Do you need to see some other part?

1 Like
192

Sorry, have been busy these few days (and will be for the next few). Putting this on my todo list for the coming days.

193

I’m having trouble trying to repro this. Could I trouble you to correct me if I am misunderstanding?

Settings:

image
image783×568 45.6 KB

Category logo → not set
Site logo → set

What I see:

image
image1477×317 46.1 KB

194

The category logo is set, but not shown. It’s visible in the default banner core shows while the forum is in safe mode

But with the component the site logo is shown

195

@tknospdr I have fixed this bug in this PR. Please report back if you face any problems.

1 Like
196

Forgive my ignorance, how do I install a PR?

197

PR stands for pull request

What Nate is saying is that he has made a pull request against the source code of Discourse and when his ‘pull request’ is ‘merged’ it will become part of the software and all users of Discourse will get the updated version with the fix

edit to add: in other words, you can’t install a PR, you will simply update your Discourse instance to get the fix

1 Like
198

I have merged it. You can just update your component.

199

Awesome, thanks. Works now!

1 Like