# Discourse failed to backup on stable

**URL:** https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682
**Category:** Support
**Created:** [2016年十一月8日 21:46 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682 "2016-11-08T21:46:39Z")
**Posts on this page:** 16
**Page:** 2

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [2016年十一月9日 22:09 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/21 "2016-11-09T22:09:47Z")

</div>

These two commits were backported to fix the specific issue you’re experiencing… 😑

@Falco, did we forget something when backporting the “fix”?

---

<div class="post-metadata">

### Author: ![Falco](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/falco/32/179432_2.png) [@Falco](https://meta.discourse.org/u/Falco)
#### Post date: [2016年十一月9日 23:45 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/22 "2016-11-09T23:45:41Z")

</div>

The only thing that changed was the mini\_racer version, I tested with a clean install and it was backing up successfully.

I will create a new install on digital ocean later today to test again, just in case.

---

<div class="post-metadata">

### Author: ![gkln](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/gkln/32/293382_2.png) [@gkln](https://meta.discourse.org/u/gkln)
#### Post date: [2016年十一月10日 06:42 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/23 "2016-11-10T06:42:47Z")

</div>

The issue was not reported on stable as far as I know.

However, I do know that the “fix” created the issue for us.

---

<div class="post-metadata">

### Author: ![pjv](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/pjv/32/115994_2.png) [@pjv](https://meta.discourse.org/u/pjv)
#### Post date: [2016年十一月10日 11:15 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/24 "2016-11-10T11:15:27Z")

</div>

Looks like the auto backup from last evening completed successfully, but again left things in a state where it thinks it is backing up. Error log shows me:  
 ![](https://global.discourse-cdn.com/meta/original/3X/c/0/c0c334a20a8560a47ba9c0529a2f3b43708a97ef.png)

stack trace:

```
/var/www/discourse/vendor/bundle/ruby/2.3.0/gems/logster-1.2.5/lib/logster/logger.rb:76:in `add_with_opts'
/var/www/discourse/vendor/bundle/ruby/2.3.0/gems/logster-1.2.5/lib/logster/logger.rb:37:in `add'
/usr/local/lib/ruby/2.3.0/logger.rb:498:in `warn'
config/unicorn.conf.rb:129:in `check_sidekiq_heartbeat'
config/unicorn.conf.rb:146:in `master_sleep'
/var/www/discourse/vendor/bundle/ruby/2.3.0/gems/unicorn-5.1.0/lib/unicorn/http_server.rb:284:in `join'
/var/www/discourse/vendor/bundle/ruby/2.3.0/gems/unicorn-5.1.0/bin/unicorn:126:in `<top (required)>'
/var/www/discourse/vendor/bundle/ruby/2.3.0/bin/unicorn:23:in `load'
/var/www/discourse/vendor/bundle/ruby/2.3.0/bin/unicorn:23:in `<main>'

```

---

<div class="post-metadata">

### Author: ![pjv](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/pjv/32/115994_2.png) [@pjv](https://meta.discourse.org/u/pjv)
#### Post date: [2016年十一月10日 19:29 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/25 "2016-11-10T19:29:54Z")

</div>

> [@zogstrip](#):
>
> Is there any chances you could update to latest?

You guys rename ‘stable’ to ‘old stuff’ and ‘latest’ to ‘stable’ and I’ll switch.

---

<div class="post-metadata">

### Author: ![gkln](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/gkln/32/293382_2.png) [@gkln](https://meta.discourse.org/u/gkln)
#### Post date: [2016年十一月11日 10:27 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/26 "2016-11-11T10:27:03Z")

</div>

Is it safe to run `redis-cli flushall` daily?

The workaround I have currently in mind is to setup a cronjob that runs:

```plaintext
docker exec data /usr/bin/redis-cli flushall

```

every night after (or before) the backup so the forum is in a good state to run the next backup.

But I’m unsure how clearing the forum state every night impacts its daily operation. Any recommandation on this matter?

Thank you. 😉

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [2016年十一月11日 16:43 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/27 "2016-11-11T16:43:46Z")

</div>

What’s preventing you from updating to latest version? That bug has been fixed and should not happen anymore. There should be no need to flush redis.

---

<div class="post-metadata">

### Author: ![pjv](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/pjv/32/115994_2.png) [@pjv](https://meta.discourse.org/u/pjv)
#### Post date: [2016年十一月11日 17:05 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/28 "2016-11-11T17:05:07Z")

</div>

> [@zogstrip](#):
>
> What’s preventing you from updating to latest version? That bug has been fixed and should not happen anymore. There should be no need to flush redis.

Why is there a version called ‘stable’?

@sam, @codinghorror : Is it an official recommendation from discourse that the correct solution to a bug in the `stable` branch is to switch to the `latest` branch? If it is, I’ll switch. If it’s not, are you guys going to fix this or what?

---

<div class="post-metadata">

### Author: ![gkln](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/gkln/32/293382_2.png) [@gkln](https://meta.discourse.org/u/gkln)
#### Post date: [2016年十一月11日 17:10 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/29 "2016-11-11T17:10:19Z")

</div>

I understand that the bug no more exists on latest. We are currently on stable, well, for feature stability. We have a development environment on beta to prepare the next stable release (mostly to deal with breaking changes that impact our CSS customizations).

Maybe it is after all a safer bet for us to use beta in production.

But what’s the point of the stable branch if it is not recommended to use anyway?

---

<div class="post-metadata">

### Author: ![Falco](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/falco/32/179432_2.png) [@Falco](https://meta.discourse.org/u/Falco)
#### Post date: [2016年十一月11日 17:30 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/30 "2016-11-11T17:30:26Z")

</div>

Guys,

Just got a brand new Droplet and the problem is still happening on stable.

I’m not sure WHY it doesn’t happen on latest. I’m not sure why it didn’t happen when I last tested it.

However, this bug is very hard to debug, because it happens in a `fork` inside a wrapper to Chrome engine that we use to parse markdown.

So, yes, we want `stable` to be stable and bug free. We know the bug is happening. And will fix as soon as possible.

* * *

If necessary you can choose to disable automatic backups and run `RAILS_ENV=production bundle exec ruby script/discourse backup` manually while we triage this.

---

<div class="post-metadata">

### Author: ![gkln](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/gkln/32/293382_2.png) [@gkln](https://meta.discourse.org/u/gkln)
#### Post date: [2016年十一月11日 19:03 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/31 "2016-11-11T19:03:35Z")

</div>

Thank you for taking the time to reproduce the bug.

Sam made these commits in an attempt to fix this bug:

[https://github.com/discourse/discourse/commit/7e43e73df69a5ca70e7f4546465525c7392612fb](https://github.com/discourse/discourse/commit/7e43e73df69a5ca70e7f4546465525c7392612fb)

[https://github.com/discourse/discourse/commit/c995fd65be3896de23c00c3d063cb9e4c55f24d8](https://github.com/discourse/discourse/commit/c995fd65be3896de23c00c3d063cb9e4c55f24d8)

They are not on stable. Aren’t they required to fully fix the bug?

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [2016年十一月11日 22:12 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/32 "2016-11-11T22:12:58Z")

</div>

You’re right 👍 We **_only_** backported the first 2 commits which were parts of the fix… We’ll get it fixed pretty soon (_unless there’s a merge conflict…_)

---

<div class="post-metadata">

### Author: ![Falco](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/falco/32/179432_2.png) [@Falco](https://meta.discourse.org/u/Falco)
#### Post date: [2016年十一月14日 21:52 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/33 "2016-11-14T21:52:18Z")

</div>

Hey guys, sorry this is my bad.

Version 1.6.7 with working backups is now out.

---

<div class="post-metadata">

### Author: ![pjv](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/pjv/32/115994_2.png) [@pjv](https://meta.discourse.org/u/pjv)
#### Post date: [2016年十一月15日 11:14 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/34 "2016-11-15T11:14:14Z")

</div>

Clean auto backup last night with v. 1.6.7. Thanks for fixing it.

---

<div class="post-metadata">

### Author: ![gkln](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/gkln/32/293382_2.png) [@gkln](https://meta.discourse.org/u/gkln)
#### Post date: [2016年十一月16日 07:13 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/35 "2016-11-16T07:13:27Z")

</div>

I confirm. Things seem to run smoothly again. Thanks!

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [2016年十一月16日 07:20 UTC](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682/36 "2016-11-16T07:20:12Z")

</div>



[上一頁](https://meta.discourse.org/t/discourse-failed-to-backup-on-stable/52682.md?page=1)
