Discourse General Polish prior to V1


(Erick Guan) #13

This can be simply done by adding display: inline-block. I can make a pull request.
But I have to ask a question here. Should we always show the user name just on the right of the avatar?


(Kane York) #14

That seems to mostly work (we still have two resizes, but they flow into each other better), but it also seems to break the act of closing them.

So some JS updates will be needed as well.


Syncing the editor viewport scroll
(Erick Guan) #15

Add display:inline-block to h1, not the poster_expansion div.

https://github.com/discourse/discourse/pull/2038


(Nick) #16

I would like to try to tackle the new post jitter. :slight_smile:


Syncing the editor viewport scroll
(Luke S) #17

This is not specific to Mac. I’m seeing it on WIN 7 pro as well. (I think. For me, it actually displays the entire first page full of the topic.) Used to see it more often, then it kind of stopped. Have noticed that it’s happening again in the last couple of weeks.

It is also not specific to going back to “Latest.” I just tried, and got this behavior on “New” as well. (The topic I tried was longer - actually the posts that @codinghorror pulled out of this topic. Perhaps you have not noticed this because most of the postes you reach from new are short, and have not been scrolled?)

EDIT: And, also, now that I have had a chance to confirm, if you got there from “Unread.” Seems to be a general part of the Back Button behavior on chrome.


(Erlend Sogge Heggen) #18

I know! I’ve experienced all sorts of weird issues with Chrome on OS X. They might make a Firefox user out of me, which I bet was their evil plan all along.

More on topic, I’d like to humbly suggest revisiting the sticky index menu.


(Larry Salibra) #19

Couple of iOS safari polish issues:

  1. Notification badge is causing weird issues - look at borders better notification icon & search icon.

  2. Weird layout of topic footer buttons


(Jeff Atwood) #20

#1 there is a straight up regression! can you look at it @awesomerobot?


(Erick Guan) #21

It seems we’d better implement this for Ember.js?


(Ryan Vergeront) #22

I opened a PR for this:

https://github.com/discourse/discourse/pull/2050


(Erick Guan) #23

We should control the length of the name(long version). It just can be too large…


(Paul Apostolos) #24

What about changing the site setting strings to proper labels? I know most of us understand:

But if I hand the site over to a non-programmer type, he might see this and be like O_o

What if human readable labels could be displayed and the title (tool tip) could be the actual site setting?

Just a suggestion.


(Bill Ayakatubby) #25

Each setting’s description to the right is already a human-readable label.


(Paul Apostolos) #26

Ummmm…Yeah, I get that.

But, to me, it looks a bit out of the ordinary. I think you would be hard pressed to find many other websites that have all lower-cased and underscored labels for form elements.

Enable Flash Video Onebox

is more polished looking to me than

enable_flash_video_onebox

It was just a suggestion, take it or leave it


(Sam Saffron) #27

Really appreciate the pull request, but now @codinghorror’s usercard is all messed up.

Can you fix that?


Width of the usercard
(Sam Saffron) #28

Because of this :slight_smile:

https://github.com/discourse/discourse/commit/89b62e133d482c7ef36f5729ba9f72b940b4adaf

^^^ GOD THE HUGE AVATAR


(Nick Caldwell) #29

Coming to this late, but it’s worth laying in more detail why this is wrong:

  1. Yes, the extended description is human-readable, but no, that’s not a substitute for a good concise label.
  2. Labels are for quick scanning. Entirely lower-cased and underscored labels are not quickly scannable.
  3. Imagine how screen readers are going to read out the text for blind users.

(Kris) #30

That’s happening because of the default onebox thumbnail image size!


(Kane York) #31

Discourse is now version 0.9.9!

https://github.com/discourse/discourse/commit/bc5896e7a40278c88b2cf091e9ebcf544433952d

Now with fixed avatar sizes :wink:


Allowing users to subscribe to new posts by category
(Wojciech Zawistowski) #32

@sam

This one:

is done

https://github.com/discourse/discourse/pull/2211