Discourse Keybase Proof

So the only way now with the plugin is manual whitelisting? That sounds .. bad? cc @sam

1개의 좋아요

Yep, it’s both to stay clear in the legal sense and to avoid getting spammed, if the system is tested out a bit more they might lift the restriction but who knows. It’s all very new.

1개의 좋아요

https://keybase-test.demo.discourse.org/ is up and running with the plugin deployed. Can you authorize that URL?

@emanuele the plugin is enable and installed.

Where in the UI I start the linking process ?

1개의 좋아요

I am not sure what you mean with “linking process” :smile: this is what I would do:

The URL you have to provide to Keybase is /keybase-proofs/config, which will allow the site to be whitelisted, and from then, you can use Keybase to identify you on that server. The URL used to do the identification dance is /keybase-proofs/new-proof (but you won’t visit it directly, but through Keybase).

Please note again that the config lacks a required param yet, so the whitelisting might be rejected if not forced by someone from Keybase.

To review it, try to visit /keybase-proofs/new-proof with the required query params (check the tests to have an idea), so you can see the UI (which is… To be tweaked :slight_smile: )

1개의 좋아요

Oh I see, so it is something that will always start from the Keybase site?

@kb_xgess I think it makes sense to have some sort of deep linking so we can add a button in the user profile and forward the user to the appropriated place in the Keybase website?

And how can we fix that?

I didn’t know where I can retrieve an SVG logo of the Discourse site. If it is somewhere, then just add a reference to it in the config (the “logo” field). If Discourse doesn’t provide one, then it is necessary to add an admin page from which the user can upload the svg logo.

(Sorry for the brevity, I am writing from my phone)

1개의 좋아요

We don’t have a site setting to provide a SVG logo currently, so just hardcode the value to this image for now in the plugin:

2개의 좋아요

Will do tomorrow :slight_smile: do you also have a black and white version of that svg? Both versions might be required by the plug-in, I think.

1개의 좋아요

awesome. i’ll get on setting up for that domain. and i’m looking into deep linking. will update.

4개의 좋아요

Latest master now contains a working config! :slight_smile:

Yes. And once the identity has been confirmed, you’ll also see your Keybase identities in your profile page (connector: user-profile-secondary).

3개의 좋아요

Amazing, https://keybase-test.demo.discourse.org/ is updated with latest!

So now the only blocking is keybase? cc @kb_xgess :wink:

4개의 좋아요

nope! should be up and running now. although i didn’t look at your config changes; i took some liberties to get it to work. anyway, it’s hidden by default, but there are three currently non-existent keybase users you can create to test it out. they are testdiscourse1, testdiscourse2, testdiscourse3. so, if you signup with those names, Test Discourse should be a paramproof option. :crossed_fingers:

5개의 좋아요

Doing it now!

and it failed @emanuele

Also closing the error modal get me stuck at a blank page (just the header) with the location bar showing https://keybase-test.demo.discourse.org/keybase-proofs/new-proof?kb_username=testdiscourse3&username=falco&sig_hash=longhashremoved&kb_ua=website

2개의 좋아요

That’s too bad :frowning: Any way in which I can reproduce?

EDIT: probably found the issue. @Falco can you update to latest master and try again?

3개의 좋아요

i think i see the problem. you’re using domain incorrectly. it should be keybase-test.demo.discourse.org not https://keybase-test.demo.discourse.org in the config (which i changed) and also when you pass it to the proof_valid endpoint. check out https://keybase.io/docs/proof_integration_guide.

4개의 좋아요

That’s exactly what I just fixed :smiley: :partying_face: :tada:

5개의 좋아요

oh wait, in the config too? Alright, fixing it there too :smiley:

@kb_xgess, @Falco, alright. I have removed “https://” from the config and from the Keybase API calls I do in lib/proof.rb (to check for a valid proof).

2개의 좋아요

Updated and now it works!

8개의 좋아요

Any way I could test it out using the official desktop client?

1개의 좋아요