Discourse Retort

커스터마이징 플러그인
481

With huge thanks :pray: to the sponsorship of @Hifihedgehog and the community of:

https://forum.tabletpc.review/

This has been brought back into compatibility and is no longer broken with 3.2.

https://github.com/gdpelican/retort/pull/87

NB: as per The Team and Sam, it is intended that the Reactions plugin will take on the additional features of this plugin (mainly the ability for multiple reactions) at some point in the future and hopefully (not yet confirmed) this will include provision of a migration tool.

9개의 좋아요
TypeError: this.model is undefined for anonymous user when loading topic
482

Seem like there might be an issue :sweat_smile: - I’m going to take a look.

3개의 좋아요
483

Fix has been merged:

https://github.com/gdpelican/retort/pull/88

8개의 좋아요
484

For those who are interested, this fork maintained by SJTU Shuiyuan community staff also works: (:warning: also installing this version will destroy your data used in the primary repo :warning:, see @merefield’s post below)

https://github.com/ShuiyuanSJTU/retort

485

Why was there no PR?

Also I might point out though, on this fork, there are no:

  • Front end tests
  • Working back-end tests
  • GitHub workflow
  • Modern linting configs

Which are now implemented on the primary repo :+1:

:warning: Also installing this version will destroy your data used in the primary repo :warning:

I see no warning of this in the README.

So I cannot recommend people even try that fork unless on a fresh instance with no history or you intend to rely on the author to maintain things in the future …

3개의 좋아요
486

Maybe they are students, who are not fully open source enthusiast, or just lazy? :sweat_smile:

487

hmmm … no doubt some significant effort has been put into it, but not actively communicating and sharing this work with the community is not ideal because it leads to some level of duplication and in this case it destroys the data used in the primary repo! That alone should have been a really good reason to PR so the approach could have been reviewed and harmonised across the forks. Now these forks are incompatible and if you install this one, there is no going back! :man_facepalming:

11개의 좋아요
488

I’ve been using this plugin for years.

There was a change that ruined it, they moved the retorts in-line with the post controls, this ruined it on mobile, if the retort container stayed above the post controls like in this post Discourse Retort - #383 by Vaping_Community it would still be amazing, the ability to retort multiple times was a feature enjoyed by all

The new reaction plugin is good but it shows only one reaction.

Is it this line in the code that decides where to put the retort-container?

api.decorateWidget("post-menu:before-extra-controls", (helper) => {

On mobile it should be something like this?
api.decorateWidget("post-contents:after-cooked", (helper) => {

Tried doing something with CSS but no joy

IMG_0739
IMG_0739731×1117 76.8 KB

489

Ok so I did a thing but I have no idea what I’m doing… I’ve been using this plugin since 2018

@merefield Please advise how to credit on my GIT, I really have no clue on how anything works

Git is here: https://github.com/GrubbyVc/Retort-Reloaded

I cloned the retort plugin and edited it to display the retort-container above the controls again, this allows for multiple retorts on mobile. I wanted to change it only for mobile but didn’t know how.

Note: This is the only change I made

Change

Changed this line in retort-init.js.es6

api.decorateWidget("post-menu:before-extra-controls", (helper) => {

To this

api.decorateWidget("post-contents:after-cooked", (helper) => {

Desktop

Screenshot 2024-08-17 001154
Screenshot 2024-08-17 0011541053×261 24.7 KB

Mobile

Screenshot 2024-08-16 235830
Screenshot 2024-08-16 235830466×275 24.2 KB

CSS

Common

.topic-post.retort, button.post-retort {
    padding: 8px !important;
}

.post-retort {
    border: none;
    padding: 2px !important;
    background: rgb(0, 0, 0, 0);
    
    &:hover .post-retort__tooltip {
    opacity: 1;
  }

  &__tooltip {
       opacity: 0;
    transition: .5s opacity;
    position: absolute;
    bottom: 65px;
    font-size: 12px;
    text-align: center;
    min-width: 125px;
    max-width: 150px;
    background: var(--primary);
    color: var(--secondary);
    font-weight: bold;
    padding: 5px;
    border-radius: 5px;
    word-wrap: normal;
    left: auto;
    transform: translate(-50%, 0);
    z-index: 1;
    pointer-events: none;
    word-break: break-word;
    &:after {
      content: " ";
      width: 7px;
      height: 7px;
      bottom: -5px;
      left: 44%;
      transform: rotate(45deg) translate(-50%, 0);
      position: absolute;
      background: var(--primary);
    }
}

&__count {
    font-size: 12px;
    padding: 1px;
    position: relative;
    bottom: 1px;
    left: 1px;
    font-weight: bold;
    color: var(--primary-medium);
  }
}

.post-retort-container {
    background: rgb(0, 0, 0, 0);
}

.emoji-picker.opened.has-limited-set {
    height: 159px;
    background-color: #333 !important;
}

Mobile

.emoji-picker.opened.has-limited-set {
    top: 400px;
}
1개의 좋아요
491

Generally it’s bad practice to create a new repo with a new name.

What you should consider doing is forking the main repo (which is easy there is a simple button), apply your changes to your fork and then later once you are fully happy and if you think the changes might be generally useful you PR to the main repo. Someone (usually the “maintainer”) will review your PR, possibly make some suggestions, allow you to update your PR and then merge it into the main repo.

That is best practice.

5개의 좋아요
492

Ah, I will look in to that asap, thanks for the advice :+1:

1개의 좋아요
493

The main reason for doing this is that then all maintenance activity can be focussed on one repo which is far far more efficient. (which you will possibly discover when there is a breaking change!)

4개의 좋아요
494

Makes a lot of sense

2개의 좋아요
495

Hi all. We’re big fans of Retort over on my Community. The latest discourse versions are making the plugin incompatible. See here. I’m trying, slowly, to make proper updates to the plugin but javascript is not my strongest area so am struggling to get it to work.

As part of our continuous effort to improve the Discourse codebase, we’re removing uses of the legacy “widget” rendering system, and replacing them with Glimmer components.

Can anyone take a look at the plugin and this notice and comment/advise as to what is needed? Maybe I’ll figure it out but wanted to bring it up that this plugin needs some TLC. Any help or contributions would be appreciated. I’m not sure if I’ve even done it properly but I have a draft PR open that is definitely a work in progress.

1개의 좋아요
496

As I understand it, the official Reactions function still doesn’t support multiple reactions per user. As some of us argued all along, this was a poor design choice from the beginning. People should be able to express multiple reactions, and those tools which support that are simply a better experience.

Until that’s changed in Reactions somehow, losing Retort would be tragic. I hope someone can update it to keep it working. Just want to thank anyone who is working on this or might consider it…

497

정말 상황에 따라 다릅니다. 많은 플랫폼은 게시물에 직접 사용할 수 있는 반응(이모지)을 1개만 제공합니다. 커뮤니티에 따라 이모지가 난무하는 혼란을 방지하기 위해 이 방식을 선호하기도 합니다.

개인적으로는 Retort를 좋아합니다. 당시에는 단순하고 평범한 '좋아요’보다 더 큰 효과를 볼 수 있었거든요. 사실 제 포럼 중 하나에서는 일반 이모지 반응과 Retort를 동시에 사용하기도 했습니다. 대부분의 사용자가 이모지를 절제해서 사용했기 때문에 잘 작동했습니다.

위 게시물에 대해 관련 지식이 있으시다면, Retort가 다시 작동하도록 하는 데 도움이 될 수 있습니다.
팀에서 여러 반응 기능을 추가할 계획이라고 했으니 언젠가 도입될 것이라고 확신합니다. 다만 현재 진행 중인 다른 프로젝트들이 우선순위가 높기 때문에, 이 기능이 우선순위 목록에 높게 올라 있지는 않을 수 있습니다.

대규모 변경 사항으로 인해 공식 Customization > Plugin, Customization > Theme, #customization:theme-component는 물론 코어 자체를 업데이트하는 데도 내부 마감 기한을 맞추기 위해 상당한 리소스가 소모되고 있기 때문입니다.

2개의 좋아요
Text alignment with hash links like superscript
498

What’s great about Retort is communities can set a limited number of meaningful reactions. Beyond those, people can include whatever emoji in a normal reply post.

So the choice isn’t stuck between just-1 or “smorgasboard”.

I really hope the multiple-reactions official support will arrive. The transition toward that for those at risk of losing Retort is potentially very awkward. Much appreciation to everyone who has been and will in the future be able to help with this.

1개의 좋아요
499

Do we have a chance to see this plugins come back one day?

@gdpelican Is this MR blocked by something in particular? Need help? Updates based on new post menu in discourse. https://meta.discourse.o… by dtraleigh · Pull Request #92 · gdpelican/retort · GitHub

The new Discourse reaction system is very sad compared to this one.

500

Well, there has been a PR opened to add this:

501

IMO, what made Retort essential was not any-emoji but multiple reactions per-user. The whole idea of users only allowed one reaction is very bad design. I did see the intention stated to eventually have the official Reactions support this, but it needs a major overhaul to do that since it wasn’t designed for that initially.

3개의 좋아요