# Discourse tests failed on Travis -- Safe to upgrade?

**URL:** https://meta.discourse.org/t/discourse-tests-failed-on-travis-safe-to-upgrade/81443
**Category:** Support
**Created:** [February 25, 2018, 12:03am UTC](https://meta.discourse.org/t/discourse-tests-failed-on-travis-safe-to-upgrade/81443 "2018-02-25T00:03:38Z")
**Posts on this page:** 5
**Page:** 1

<div class="post-metadata">

### Author: ![ChrisBeach](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/chrisbeach/32/214628_2.png) [@ChrisBeach](https://meta.discourse.org/u/ChrisBeach)
#### Post date: [February 25, 2018, 12:03am UTC](https://meta.discourse.org/t/discourse-tests-failed-on-travis-safe-to-upgrade/81443/1 "2018-02-25T00:03:38Z")

</div>

I’m on a self-hosted instance and like to stay up-to-date with Discourse core.

Sometimes I get nervous about upgrading as the latest build has failing tests:

 ![52](https://global.discourse-cdn.com/meta/original/3X/3/0/30cf939b6aca3a181f9ea1d1ef8240d6778d1fb9.png)

I’m on the master branch (I think):

```plaintext
$ cd /var/discourse
$ git status
On branch master

```

So I wondered if perhaps I should switch to the [`tests-passed`](https://github.com/discourse/discourse/tree/tests-passed) branch instead - hoping that this would contain the latest revision whose CI build and test phases had succeeded. However, it seems `tests-passed` [is unstable](https://travis-ci.org/discourse/discourse/branches):

 ![01](https://global.discourse-cdn.com/meta/original/3X/1/3/13c5b040ca6e7273266775f596a9f33f77999f8c.png)

So I’m a bit confused, and a bit scared 😨. I’d like to take in some recent updates to Discourse core - is there a way I can upgrade to a known-good version?

---

<div class="post-metadata">

### Author: ![gerhard](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/gerhard/32/119479_2.png) [@gerhard](https://meta.discourse.org/u/gerhard)
#### Post date: [February 25, 2018, 12:09am UTC](https://meta.discourse.org/t/discourse-tests-failed-on-travis-safe-to-upgrade/81443/2 "2018-02-25T00:09:55Z")

</div>

The Travis build is having problems lately. But tests-passed is perfectly fine. It’s deployed on meta and passed all tests on our internal build server.

---

<div class="post-metadata">

### Author: ![featheredtoast](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/featheredtoast/32/116994_2.png) [@featheredtoast](https://meta.discourse.org/u/featheredtoast)
#### Post date: [February 25, 2018, 12:10am UTC](https://meta.discourse.org/t/discourse-tests-failed-on-travis-safe-to-upgrade/81443/3 "2018-02-25T00:10:42Z")

</div>

If you’re on a [standard install](https://meta.discourse.org/t/142537?silent=true), your “master” branch in `/var/discourse` is the discourse\_docker repository: [GitHub - discourse/discourse\_docker: A Docker image for Discourse · GitHub](https://github.com/discourse/discourse_docker)

With a [standard install](https://meta.discourse.org/t/142537?silent=true), “tests-passed” is the default branch. I can’t speak to why tests aren’t passing 100% of the time, but my understanding is that the test suite passed in master once before for that branch.

TLDR, I’ve found tests-passed pretty safe.

---

<div class="post-metadata">

### Author: ![ChrisBeach](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/chrisbeach/32/214628_2.png) [@ChrisBeach](https://meta.discourse.org/u/ChrisBeach)
#### Post date: [February 25, 2018, 1:30am UTC](https://meta.discourse.org/t/discourse-tests-failed-on-travis-safe-to-upgrade/81443/4 "2018-02-25T01:30:33Z")

</div>

Thanks guys. I’ve upgraded.

---

<div class="post-metadata">

### Author: ![JammyDodger](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/jammydodger/32/254611_2.png) [@JammyDodger](https://meta.discourse.org/u/JammyDodger)
#### Post date: [June 8, 2024, 12:37pm UTC](https://meta.discourse.org/t/discourse-tests-failed-on-travis-safe-to-upgrade/81443/5 "2024-06-08T12:37:50Z")

</div>

This topic was automatically closed after 2295 days. New replies are no longer allowed.
