Yeah I definitely didn’t optimize against having a large set of users. Mostly just wanted to get a proof of concept going as the plugin system seems like the most maintainable way for me to build features that are really not suited for core Discourse without having to fight through merge conflicts.
Translations in gem, awesome, will do!
I was initially using the BasicUserSerializer but had ripped it out when I was having trouble with some ember bindings, but I forgot to add that back in. In my own instance I’m also wanting to add some values to the user record, so I’ll probably need to then construct my own serializer.
Generally I’m happy to see how you are using serialization as I’m working on another project now that my collaborator wants to use an MVVM architecture, and Active Model Serializers seems like a good Rails way to accomplish the view model aspect.
Yes, I definitely think a hook for menu items would be a good addition. I’m almost questioning the validity of specifying allowed menu items in the ember app. I suppose it provides the benefit of not adding a broken nav item if an admin were to simply add a new value to the pipe separated list in site settings?
I’d be happy to take a crack at that. My first thought would be to add a method similar to the register_assets method called on plugin installation that would push a string into the array of allowed nav items?
Thanks for the feedback! Am really loving Discourse so far and hope to build out a couple more plugins. An events plugin would probably be next for me, but I’ll also flesh this out more as well. Keep up the good work!