"Dismiss" button on "Unread" page causes topics to be muted

(David Taylor) #1

I think this could be part of the problem I’m having here, but it definitely doesn’t account for all of the issues.

To reproduce:

  1. Go to your “Unread” page
  2. Click the “Dismiss” button
  3. Tick the box to say “stop tracking these topics”
  4. Go to one of the topics that you just dismissed
  5. See that it has been muted :scream:

Expected behaviour:

  • The topic should be set to “normal” tracking mode

I can reproduce consistently on my forum, and here on meta.

Looking in dev tools, I see a PUT request to /topics/bulk, but the only data in the request is:

filter: unread
operation[type]: change_notification_level

I’m pretty sure there should be a notification_level_id specified in that request. So my guess is that the server is interpreting the lack of notification_level_id as a 0 (zero), which corresponds to muting the topics.

(Jeff Atwood) #2

Yeah this looks like a legitimate bug. Excellent sleuthing again @david! :male_detective:

(Neil Lalonde) #3

Fixed! Brackets are important.

(Jeff Atwood) #4

(Kane York) #5

Perhaps also add a check on the server so it rejects the request if notification_level_id is blank, to prevent anything similar in the future?