忽略“可用升级”通知导致 422 错误

zogstrip · 2025 年12 月 27 日 23:00

抱歉，@RBoy，我们需要对 DEV: 移除销毁问题检查跟踪器时的管理员通知进行一些后续跟进

github.com/discourse/discourse

FIX: Dismissing admin notices fails with 422 when tracker has NULL target

main ← fix-dismissing-admin-notices-fails-with-422-when-tracker-has-null-target

opened 10:59PM - 27 Dec 25 UTC

ZogStriP

+40 -1

When dismissing an admin notice, the service would look up the associated `Probl…emCheckTracker` by identifier only. This could find a tracker with a `NULL` target, which then fails validation on update since target is now required (as of 8ca5fb706a). The root issue is that `problem_check_trackers.target` was added with `null: true` and while we later added a default value of `"__NULL__"` and a Ruby validation, we never enforced `NOT NULL` at the database level. This allowed records with `NULL` targets to persist or be recreated through code paths that explicitly passed nil. This commit: - Updates the dismiss service to look up trackers by both identifier AND target (extracted from the admin notice's details) - Removes any remaining records with `NULL` targets - Adds a `NOT NULL` constraint to prevent this from recurring Ref - https://meta.discourse.org/t/392248

话题		回复	浏览量
'Dimiss Unread' Button is broken on latest Bug	3	913	2016 年12 月 5 日
Production.log give No method error and Discourse not working Support	9	1233	2020 年1 月 9 日
Upgrade failed: null value in column "updated_at" violates not-null constraint Support	5	2645	2017 年8 月 10 日
Maybe a bug on meta, post disappeared Site feedback	26	5074	2017 年4 月 16 日
40 Fatals and 7 Errors in recent logs Support	13	1585	2024 年6 月 8 日

忽略“可用升级”通知导致 422 错误

相关话题