"Download Remote Images" setting reset during upgrade?


(Dean Taylor) #1

It’s starting to feel like the download_remote_images_to_local setting is reset during the docker upgrade process.

I keep on having to turn the setting back “on”.

It doesn’t look like anybody else is turning it off…

Any ideas?

Cheers,
Dean.


Disk space and backup failure notifications
Are you using a real user to send welcome messages?
(Tobias Eigen) #2

Not happening on my site.


(Régis Hanol) #3

Not happening here on meta either.


(Dean Taylor) #4

Any other ideas on what might be causing it?


(Dean Taylor) #5

I think I’ve spotted where it’s happening.

Due to recent testing on the backup issue disk space may have run low.


(Dean Taylor) #6

Perhaps if this happens a notification could be added to the logs?


(Régis Hanol) #7

Hmm, this is what this line is supposed to do…

SystemMessage.create(Discourse.site_contact_user, :download_remote_images_disabled)

(Dean Taylor) #8

I can’t see it in any of these locations:

  • My personal notifications
  • /admin/logs/staff_action_logs
  • /logs
  • My emails
  • /users/system/notifications

Is there somewhere else I’m supposed to look?


(Régis Hanol) #9

I just pushed a fix :sheep:

https://github.com/discourse/discourse/commit/5681338b089849c7bb9dabd4efbe8276a8929605

Discourse will now log a new staff action and send a private message from the system user to the site contact user.


(Régis Hanol) #10

(Régis Hanol) #11

(Dean Taylor) #12

Hi @zogstrip,

Thanks for re-opening

This has happened again.

You might gleam more detail from my other recent post regarding disk space / backup failure notifications, but I will go though the basics here.

So the option download remote images turned off again…
… and I didn’t receive a notification.

To be clear I have the following settings:

The user system did not have an email address specified.
I have just now set one up for this user.
Nobody logs in as system normally.

I have checked all admins and system and not one of them received any notification.
I have checked mandrill and not one email was sent regarding this.

I can see that system changed the setting here:

Any thoughts on why I wont be getting notifications for these events?

Obviously an email notification as well is preferable.

Cheers,
Dean.


(Kane York) #13

The site_contact_username is the one being notified of the setting being changed. Change it to your user.

And you should probably get more disk space for the forum. You can do this by:

  1. Make an announcement, set forums to read-only
  2. taking a full backup,
  3. downloading the backup,
  4. setting up a new VPS with more disk,
  5. installing discourse on the new VPS,
  6. uploading the backup and doing a restore,
  7. switching over DNS.

(Dean Taylor) #14

@riking thanks for your feedback.

Notifying the site_contact_username doesn’t make sense in this case.

You say “notified” but if this is true, then its only via email as no actual notification was seen by the system account.

There is a very clear separation between technical and forum contact, I only play the technical role and am not a community manager.
Any of the other two contact methods contact email or notification email would make more sense for this.

I would consider this a critical notification or an essential system email as it directly impacts the forum functionality.

It doesn’t make sense for my username to be used to sent the invite / intro messages to new sign ups or for notifications of edits made by the image downloader edits.


(Jeff Atwood) #15

I believe this is fixed as the disk space calculation that triggers this settings change was incorrect and only fixed recently by @sam.


(Jeff Atwood) #16