Drop-down-visible class persists even when drop down is not visible anymore

(Joe) #1

Discourse adds the class drop-down-visible to the <body> element when a drop-down is visible.

Screenshots here on meta:

No drop down:

drop down visible (hamburger menu):

This is a very handy class, but isn’t it supposed to be removed when the drop-down is no longer visible?

Here’s a screenshot after closing the hamburger menu above:

Note that the class drop-down-visible is still present.

The same happens with the notification drop-down and the search drop-down.

Discourse Vincent theme
(Jeff Atwood) #2

That does seem odd @eviltrout we must not need this class?

(Robin Ward) #3

This class could probably use a better name. drop-down-visible indicates whether the header will use a dropdown vs the docked format of the navigation (generally with a smaller browser width.) It is currently being used.

(Jeff Atwood) #4

I suggest we rename it, then?

(Robin Ward) #5

Should do it.

(Robin Ward) #6