Dropdown for option under Settings > Files is broken


(Aahan Krish) #1

Admin > Settings > Files > ‘disabled_image_download_domains’ option. The dropdown for this option is broken (at least in the latest versions of Firefox & Chrome on Windows 7).

PS: Discourse wasn’t allowing disabled_image_download_domains in the title, hence the undescriptive title.


(Neil Lalonde) #2

That site setting allows a list of values, but doesn’t offer any choices.

Compare it:

  disabled_image_download_domains:
    type: list
    default: ''

with this one:

  share_links:
    client: true
    type: list
    default: 'twitter|facebook|google+|email'
    choices:
     - twitter
     - facebook
     - google+
     - email

It shouldn’t be trying to show the list of choices in that case.


(Sam Saffron) #3

Note, the duplication there is kind of awkward. Perhaps a magic key should be added? not sure:

 share_links:
    client: true
    type: list
    default: ALL
    choices:
     - twitter
     - facebook
     - google+
     - email

(Neil Lalonde) #4

I made this change today, and improved the styling of those list inputs.


(Jeff Atwood) #5