Duplicate JSHint excludes config


(Wojciech Zawistowski) #1

There are two places where you can specify files excluded from JSHint linting:

  • .jshintignore
  • test/javascripts/jshint_all.js.erb

.jshintignore influences Travis (but doesn’t exclude file when running tests in browser via /qunit URL while jshint_all.js.erb excludes files from browser runner but doesn’t influence Travis.

Ideally this should be merged into a single configuration, in a single place.


(Robin Ward) #2

I’ve got a patch for this now, thanks for finding it:

https://github.com/discourse/discourse/commit/36bb4c02b7efc4d59c3d8a5fdf159e51b9994b25

Now it will use the ignore file for everything :smile:


(Jeff Atwood) #3