Edit Category, Bug or Feature?


(Arpit Jalan) #1

I just noticed Edit Category button, which I am pretty sure was not there before:

//discourse-meta.s3-us-west-1.amazonaws.com/original/2X/7/7cf9258fbed573e50ee3300ed41c7983ede2209c.png

On clicking the button, it is showing a popup to change Category Name to Normal Users, see below screenshot:

//discourse-meta.s3-us-west-1.amazonaws.com/optimized/2X/c/c23a46a953ee6ad405b31d952cb569d8893a1509_1_600x500.png

Why does a Normal User should have the ability to change Category Name? When I tried to change the Category Name in the popup, nothing happened, no error message or success message, and the Category Name was not changed, so I checked the console and it was showing the following error:

//discourse-meta.s3-us-west-1.amazonaws.com/original/2X/c/cabbea1fa78f499b92cd687fece73732a4f0a337.png

Secondly, the second tab in popup allowed Normal Users to modify Security Settings of the Category:

//discourse-meta.s3-us-west-1.amazonaws.com/optimized/2X/e/e8a88d3fa86c5e2ee14932cea6f1a9f41d3632a7_1_600x500.png

In this case also when I pressed Save nothing happened, no error message or success message, and the change was not reflected, again I checked console, and it was showing following error:

//discourse-meta.s3-us-west-1.amazonaws.com/optimized/2X/3/3e2be9665e3ed3262171e31d887e3e3767a6ef83_1_690x333.png

I think in both of the above cases, it was the right thing to not reflect my changes globally, as I am a Normal User and the permission of changing Category Name and Security Setting should be available only to Admin.

I can’t be sure whether it’s a bug to show Edit Category button to Normal Users or Intended Feature.

cc @sam, @codinghorror, @eviltrout , @zogstrip


(Sam Saffron) #2

Yeah “Edit Category” should only be there for admins and mods , this is a regression


(Jeff Atwood) #3

And trust level 3 but nobody should be TL3 at the moment. Probably just work in progress by @neil.


(Sam Saffron) #4

Not sure about that, why would they ever need access to Edit Category?


(Jeff Atwood) #5

Oh true I was thinking of renaming topics and recategorizing topics, my bad. Creating categories is way beyond that.


(Régis Hanol) #6

Thanks for reporting it! It’s now fixed:

https://github.com/discourse/discourse/commit/5ec22cdd23d31a5c2718e97d50cabd6c5682be0c


(Régis Hanol) #7