Edit Conflict on Wiki Posts

nbianca · July 22, 2021, 2:44pm

Your code was good, but MessageBus API changed at some point and it did not work anymore. I fixed two bugs related to this in a PR:

github.com/discourse/discourse

FIX: Long poll if window becomes active

discourse:main ← discourse:fix_message_bus

opened 02:41PM - 22 Jul 21 UTC

nbianca

+4 -8

This commit fixes two bugs. The first one is that onPresenceChange was called w…ith invalid arguments and it did not register a callback. The second bug is that it triggered the wrong visibilitychange event. The function it tried to call does not exist in all versions of MessageBus. It is safer to trigger an event instead because that exists in all versions. The test was intentionally omitted because we do not test MessageBus and it requires a lot of stubs which do not make the test useful anymore.

Topic		Replies	Views
Error message when editing posts support	13	810	June 16, 2021
Edit Conflict: That post was edited by another user and your changes can no longer be saved bug	24	1934	June 26, 2021
Editing wiki posts at same time as someone else sometimes loses revisions feature composer , wiki-posts	29	7230	May 11, 2019
Off-by-one loses latest revision bug shared-edits	5	643	August 26, 2023
Possible Race Condition when editing a post bug	1	754	January 29, 2021

Edit Conflict on Wiki Posts

Related Topics