# Edited text for flagging dialog not showing

**URL:** <https://meta.discourse.org/t/edited-text-for-flagging-dialog-not-showing/83095>\
**Category:** Bug\
**Created:** [March 15, 2018, 6:59pm UTC](https://meta.discourse.org/t/edited-text-for-flagging-dialog-not-showing/83095 "2018-03-15T18:59:48Z")\
**Posts on this page:** 5\
**Page:** 1

## AI-generated summary

The issue involves edited text in the flagging UI not being displayed, despite changes appearing elsewhere in the site texts. [wolftune](/t/-/83095/1) reported that edits to flagging UI text, such as `post_action_types.off_topic.description`, were not reflected, even though the text was successfully edited and searchable. [dax](/t/-/83095/2) confirmed the behavior. [wolftune](/t/-/83095/4) noted the issue was resolved after upgrading to the latest beta. [gerhard](/t/-/83095/5) explained the root cause: a cache expiration issue in `PostActionType` due to a missing locale in the cache key. The fix has been implemented in a GitHub commit, and the cache expiration logic may need adjustments for supported locales.

<div class="post-metadata">

**Author:** ![wolftune](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/wolftune/32/103569_2.png) [@wolftune](https://meta.discourse.org/u/wolftune)\
**Post date:** [March 15, 2018, 6:59pm UTC](https://meta.discourse.org/t/edited-text-for-flagging-dialog-not-showing/83095/1 "2018-03-15T18:59:49Z")

</div>

Everywhere else that I edited text in /admin/customize/site\_texts I see the results.

But for the flagging UI, e.g. /admin/customize/site\_texts/post\_action\_types.off\_topic.description , I’m still only seeing the default text. In fact, if I search for the default text to change, it doesn’t show up in search anymore since only my edited text will show in the search. But the flagging UI is just not using my text.

This is the case for all the text content in the radio-button areas, but I tested changing the “Take Action” button text and that worked.

---

<div class="post-metadata">

**Author:** ![dax](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/dax/32/244677_2.png) [@dax](https://meta.discourse.org/u/dax)\
**Post date:** [March 15, 2018, 8:28pm UTC](https://meta.discourse.org/t/edited-text-for-flagging-dialog-not-showing/83095/2 "2018-03-15T20:28:31Z")

</div>

I can confirm this behaviour

cc @gerhard

---

<div class="post-metadata">

**Author:** ![wolftune](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/wolftune/32/103569_2.png) [@wolftune](https://meta.discourse.org/u/wolftune)\
**Post date:** [March 16, 2018, 6:11pm UTC](https://meta.discourse.org/t/edited-text-for-flagging-dialog-not-showing/83095/4 "2018-03-16T18:11:13Z")

</div>

We upgraded to latest new beta, and this bug seems to be fixed!

---

<div class="post-metadata">

**Author:** ![gerhard](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/gerhard/32/119479_2.png) [@gerhard](https://meta.discourse.org/u/gerhard)\
**Post date:** [March 16, 2018, 7:21pm UTC](https://meta.discourse.org/t/edited-text-for-flagging-dialog-not-showing/83095/5 "2018-03-16T19:21:17Z")

</div>

Yeah, restarting the server fixes it.

The root cause is now fixed: [FIX: Translation overrides for flag types didn't expire cache · discourse/discourse@6c736a1 · GitHub](https://github.com/discourse/discourse/commit/6c736a1fa49fa3cb29dbc035a8529ffe66aeb129)

* * *

@sam We are trying to expire the cache in `PostActionType`, but it’s not working because of the missing locale in the key. I think this can be removed since we do not save or destroy those types. If we still need this, I guess we need to expire the cache for each supported locale.

> <https://github.com/discourse/discourse/blob/main/app/models/post_action_type.rb#L6-L14>

---

<div class="post-metadata">

**Author:** ![Falco](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/falco/32/179432_2.png) [@Falco](https://meta.discourse.org/u/Falco)\
**Post date:** [March 17, 2018, 9:00pm UTC](https://meta.discourse.org/t/edited-text-for-flagging-dialog-not-showing/83095/7 "2018-03-17T21:00:00Z")

</div>

Closed on March 17, 2018, 9:00pm UTC

This topic was automatically closed after 26 hours. New replies are no longer allowed.
