# La modifica degli argomenti con gruppi di tag dai genitori consente il tagging errato **URL:** \ **Category:** Bug\ **Tags:** tags\ **Created:** [5 Maggio 2023, 1:07pm UTC](https://meta.discourse.org/t/editing-topics-with-tag-groups-from-parents-allows-incorrect-tagging/263968 "2023-05-05T13:07:38Z")\ **Posts on this page:** 1\ **Showing post:** 6
**Author:** ![saquetim](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/saquetim/32/116400_2.png) [@saquetim](https://meta.discourse.org/u/saquetim)\ **Post date:** [15 Maggio 2023, 8:39pm UTC](https://meta.discourse.org/t/editing-topics-with-tag-groups-from-parents-allows-incorrect-tagging/263968/6 "2023-05-15T20:39:33Z")
Questo problema dovrebbe essere risolto in > > > \# FIX: Displaying the wrong number of minimum tags in the composer > > When the m…inimum number of tags set for the category is larger than the minimum number of tags set in the category tag-groups, the composer was displaying the wrong value. > > This commit fixes the value displayed in the composer to show the max value between the required for the category and the tag-groups set for the category. > > This bug was reported on Meta in https://meta.discourse.org/t/tags-from-multiple-tag-groups-required-only-suggest-select-at-least-one-tag/263817 > > \# FIX: Limiting tags to categories not working as expected > When a category was restricted to a tag group A, which was set to only allow > one tag from the group per topic, selecting a tag belonging only to A returned > other tags from A that also belonged to other group/s (if any). > > Example: > > Tag group A: alpha, beta, gamma, epsilon, delta > Tag group B: alpha, beta, gamma > > Both tag groups set to only allow one tag from the group per topic. > > If Category 1 was set to only allow tags from the tag group A, and the first tag > selected was epsilon, then, because they also belonged to tag group B, the tags > alpha, beta, and gamma were still returned as valid options when they should not be. > > This commit ensures that once a tag from a tag group that restricts its tags to > one per topic is selected, no other tag from this group is returned. > > This bug was reported on Meta in https://meta.discourse.org/t/limiting-tags-to-categories-not-working-as-expected/263143. > > \# FIX: Moving topics does not prompt to add required tag for new category > When a topic was moved from a category to another, the tag requirements > of the new category were not being checked. > > This allowed a topic to be created and moved to a category: > > \- that limited the tags to a tag group, with the topic containing tags > not allowed. > \- that required n tags from a tag group, with the topic not containing > the required tags. > > This bug was reported on Meta in https://meta.discourse.org/t/moving-tagged-topics-does-not-prompt-to-add-required-tag-for-new-category/264138. > > \# FIX: Editing topics with tag groups from parents allows incorrect tagging > > When there was a combination between parent tags defined in a tag group > set to allow only one tag from the group per topic, and other tag groups > relying on this restriction to combine the children tag types with the > parent tag, editing a topic could allow the user to insert an invalid > combination of these tags. > > Example: > > Automakers tag group: landhover, toyota > - group set to limit one tag from the group per topic > > Toyota models group: land-cruiser, hilux, corolla > > Landhover models group: evoque, defender, discovery > > If a topic was initially setup with the tags toyota, land-cruiser it was > possible to edit it removing the tag toyota and adding the tag landhover > and other landhover model tag like evoque for example. > > In this case the topic would end up with the tags toyota, land-cruiser, > landhover, evoque because Discourse will automatically insert the > missing parent tag toyota when it detects the tag land-cruiser. > > This combination of tags would violate the restriction specified in > the Automakers tag group resulting in an invalid combination of tags. > > This commit enforces that the "one tag from the group per topic" > restriction is verified before updating the topic tags and also > make sure the verification check the compatibility of parent tags that > would be automatically inserted. > > After the changes the user will receive an error similar to: > The tags land-cruiser, landhover cannot be used simultaneously. > Please include only one of them. > > This bug was reported on Meta in https://meta.discourse.org/t/editing-topics-with-tag-groups-from-parents-allows-incorrect-tagging/263968. --- _[View the full topic](https://meta.discourse.org/t/editing-topics-with-tag-groups-from-parents-allows-incorrect-tagging/263968)._