Educational message for "Starred" tab shouldn't use the <kbd> tag


(Gerhard Schlager) #1

Currently the educational message for the “Starred” tab uses the HTML tag <kbd> in order to show a box that looks a little bit like a button.

In the Star button at the bottom of the topic

In my opinion that’s just not right. It should just be used to represent keyboard input. Why not use another CSS style or use quotes (“Star”). Discourse uses the latter in several other messages to references buttons. Why not here?

BTW: I think Chrome on Android doesn’t even render the kbd tag as . AFAIK only the Desktop version does that.

One more thing: The English text has no closing </ul> tag.


(Jeff Atwood) #2

I don’t actually object to using <kbd> to make Buttons but I see your point.

I think the star glyph is enough to carry the panel, so we can remove the button markup.

But you also gave me another idea, the empty New and Unread panels should show the glyphs that they embody as well. Done!


(Jeff Atwood) #3