enable_flash_video_onebox doesn't actually do anything


(Vikhyat Korrapati) #1

The only mention of the enable_flash_video_onebox setting outside config/site_settings.yml is in the locales, I don’t think it has actually been doing anything since switching oneboxes to the external gem.

The setting was added after discussion here, I’m not sure if it is still relevant to the new onebox implementation.


(Jeff Atwood) #2

Possibly another regression based on the new oneboxes. We should support this @eviltrout.


(Robin Ward) #3

Yup, this was my fault. It’s been fixed in master:

https://github.com/discourse/discourse/commit/034287033e0c95e98d445cb1f4c281aa01851779


(Robin Ward) #4