خطأ للمستخدمين المسجلين وتعليق Git

Falco · 3 سبتمبر 2026، 4:55م

@Ed_S أعتقد أنني وجدت المشكلة ولدي طلب دمج (PR) لإصلاحها، هل يمكنك التحقق مما إذا كان يتناول المنطقة التي لاحظت فيها مشاكل؟

github.com/discourse/discourse

FIX: Stop new-feature checks reaching GitHub during requests (#43143)

main ← new-features-no-git-in-requests

merged 05:13PM - 03 Sep 26 UTC

xfalcox

+261 -33

Previously, `CurrentUserSerializer#has_unseen_features` could derive the newest …new-feature timestamp inline, which filters the feed through `GitUtils.has_commit?` — and since we deploy from a partial clone (`--filter=tree:0`), `git merge-base --is-ancestor` on a commit missing from the local graph is lazily fetched from the promisor remote, i.e. a blocking, untimed network call to GitHub, once per feed entry, in a request. Compounding it, a fully-filtered feed cached no result at all, so every logged-in page render redid the whole loop until the worker timed out. This change runs that check with `GIT_NO_LAZY_FETCH=1` under a hard timeout so it stays local and bounded, memoizes it per process, and makes `DiscourseUpdates.latest_new_feature_created_at` a plain Redis read derived on write (`update_new_features`, plus a throttled `Jobs::RefreshLatestNewFeature` to self-heal after a deploy or an upcoming change changing status).

الموضوع		الردود	مرات العرض
Fatal: could not read Username for 'https://github.com' Self-hosting	10	240	3 سبتمبر 2026
Twitter, Github and normal username and password logins not working after upgrade Self-hosting unsupported-install	34	7708	22 أكتوبر 2016
40 Fatals and 7 Errors in recent logs Support	12	1745	17 فبراير 2017
Admin users always get 500 timeout in GitUtils.has_commit?, while normal users work fine Bug	0	79	6 يوليو 2026
Google Login Stopped Working after manual update Support	5	1052	8 مارس 2019

خطأ للمستخدمين المسجلين وتعليق Git

الموضوعات ذات الصلة