Events Plugin 📆

#426

Hi @angus, there seems to be a bug with latest Discourse:

StandardError (Attempting to access a non preloaded custom field, this is disallowed to prevent N+1 queries.) /var/www/discourse/app/models/concerns/has_custom_fields.rb:158:in `[]'

/var/www/discourse/app/models/concerns/has_custom_fields.rb:158:in `[]'
/var/www/discourse/plugins/discourse-events/plugin.rb:69:in `events_enabled'
/var/www/discourse/plugins/discourse-events/plugin.rb:52:in `block (2 levels) in activate!'
(eval):31:in `_fast_attributes'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/active_model_serializers-0.8.4/lib/active_model/serializer.rb:468:in `rescue in attributes'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/active_model_serializers-0.8.4/lib/active_model/serializer.rb:455:in `attributes'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/active_model_serializers-0.8.4/lib/active_model/serializer.rb:480:in `_serializable_hash'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/active_model_serializers-0.8.4/lib/active_model/serializer.rb:359:in `serializable_hash'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/active_model_serializers-0.8.4/lib/active_model/serializer/associations.rb:124:in `block in serialize'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/active_model_serializers-0.8.4/lib/active_model/serializer/associations.rb:123:in `map'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/active_model_serializers-0.8.4/lib/active_model/serializer/associations.rb:123:in `serialize'
/var/www/discourse/lib/freedom_patches/ams_include_without_root.rb:55:in `include!'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/active_model_serializers-0.8.4/lib/active_model/serializer.rb:368:in `block in include_associations!'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/active_model_serializers-0.8.4/lib/active_model/serializer.rb:367:in `each_key'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/active_model_serializers-0.8.4/lib/active_model/serializer.rb:367:in `include_associations!'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/active_model_serializers-0.8.4/lib/active_model/serializer.rb:362:in `serializable_hash'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/active_model_serializers-0.8.4/lib/active_model/serializer.rb:347:in `as_json'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.2.1/lib/active_support/json/encoding.rb:35:in `encode'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.2.1/lib/active_support/json/encoding.rb:22:in `encode'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.2.1/lib/active_support/core_ext/object/json.rb:41:in `to_json'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/active_model_serializers-0.8.4/lib/active_model/serializer.rb:331:in `to_json'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/multi_json-1.13.1/lib/multi_json/adapters/oj.rb:40:in `dump'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/multi_json-1.13.1/lib/multi_json/adapters/oj.rb:40:in `dump'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/multi_json-1.13.1/lib/multi_json/adapter.rb:25:in `dump'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/multi_json-1.13.1/lib/multi_json.rb:139:in `dump'
/var/www/discourse/app/models/site.rb:123:in `json_for'
/var/www/discourse/app/controllers/application_controller.rb:523:in `preload_anonymous_data'
/var/www/discourse/app/controllers/application_controller.rb:350:in `preload_json'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.2.1/lib/active_support/callbacks.rb:426:in `block in make_lambda'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.2.1/lib/active_support/callbacks.rb:198:in `block (2 levels) in halting'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/abstract_controller/callbacks.rb:34:in `block (2 levels) in <module:Callbacks>'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.2.1/lib/active_support/callbacks.rb:199:in `block in halting'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.2.1/lib/active_support/callbacks.rb:513:in `block in invoke_before'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.2.1/lib/active_support/callbacks.rb:513:in `each'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.2.1/lib/active_support/callbacks.rb:513:in `invoke_before'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.2.1/lib/active_support/callbacks.rb:131:in `run_callbacks'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/abstract_controller/callbacks.rb:41:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_controller/metal/rescue.rb:22:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.2.1/lib/active_support/notifications.rb:168:in `block in instrument'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.2.1/lib/active_support/notifications/instrumenter.rb:23:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.2.1/lib/active_support/notifications.rb:168:in `instrument'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_controller/metal/instrumentation.rb:32:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_controller/metal/params_wrapper.rb:256:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/activerecord-5.2.2.1/lib/active_record/railties/controller_runtime.rb:24:in `process_action'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/abstract_controller/base.rb:134:in `process'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionview-5.2.2.1/lib/action_view/rendering.rb:32:in `process'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/rack-mini-profiler-1.0.2/lib/mini_profiler/profiling_methods.rb:78:in `block in profile_method'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_controller/metal.rb:191:in `dispatch'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_controller/metal.rb:252:in `dispatch'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_dispatch/routing/route_set.rb:52:in `dispatch'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_dispatch/routing/route_set.rb:34:in `serve'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_dispatch/journey/router.rb:52:in `block in serve'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_dispatch/journey/router.rb:35:in `each'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_dispatch/journey/router.rb:35:in `serve'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_dispatch/routing/route_set.rb:840:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/rack-protection-2.0.5/lib/rack/protection/frame_options.rb:31:in `call'
/var/www/discourse/lib/middleware/omniauth_bypass_middleware.rb:32:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/tempfile_reaper.rb:15:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/conditional_get.rb:25:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/head.rb:12:in `call'
/var/www/discourse/lib/content_security_policy/middleware.rb:12:in `call'
/var/www/discourse/lib/middleware/anonymous_cache.rb:214:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/session/abstract/id.rb:232:in `context'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/session/abstract/id.rb:226:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_dispatch/middleware/cookies.rb:670:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_dispatch/middleware/callbacks.rb:28:in `block in call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/activesupport-5.2.2.1/lib/active_support/callbacks.rb:98:in `run_callbacks'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_dispatch/middleware/callbacks.rb:26:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_dispatch/middleware/debug_exceptions.rb:61:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/logster-2.1.2/lib/logster/middleware/reporter.rb:30:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/railties-5.2.2.1/lib/rails/rack/logger.rb:38:in `call_app'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/railties-5.2.2.1/lib/rails/rack/logger.rb:28:in `call'
/var/www/discourse/config/initializers/100-quiet_logger.rb:16:in `call'
/var/www/discourse/config/initializers/100-silence_logger.rb:29:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_dispatch/middleware/remote_ip.rb:81:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/actionpack-5.2.2.1/lib/action_dispatch/middleware/request_id.rb:27:in `call'
/var/www/discourse/lib/middleware/enforce_hostname.rb:17:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/method_override.rb:22:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/rails_multisite-2.0.6/lib/rails_multisite/middleware.rb:24:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/sendfile.rb:111:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/rack-mini-profiler-1.0.2/lib/mini_profiler/profiler.rb:171:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/message_bus-2.2.0/lib/message_bus/rack/middleware.rb:57:in `call'
/var/www/discourse/lib/middleware/request_tracker.rb:163:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/railties-5.2.2.1/lib/rails/engine.rb:524:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/railties-5.2.2.1/lib/rails/railtie.rb:190:in `public_send'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/railties-5.2.2.1/lib/rails/railtie.rb:190:in `method_missing'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/urlmap.rb:68:in `block in call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/urlmap.rb:53:in `each'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/rack-2.0.6/lib/rack/urlmap.rb:53:in `call'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/unicorn-5.4.1/lib/unicorn/http_server.rb:606:in `process_client'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/unicorn-5.4.1/lib/unicorn/http_server.rb:701:in `worker_loop'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/unicorn-5.4.1/lib/unicorn/http_server.rb:549:in `spawn_missing_workers'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/unicorn-5.4.1/lib/unicorn/http_server.rb:142:in `start'
/var/www/discourse/vendor/bundle/ruby/2.5.0/gems/unicorn-5.4.1/bin/unicorn:126:in `<top (required)>'
/var/www/discourse/vendor/bundle/ruby/2.5.0/bin/unicorn:23:in `load'
/var/www/discourse/vendor/bundle/ruby/2.5.0/bin/unicorn:23:in `<main>'

Although running in safe-mode does not fix it!

I guess this one is gonna help…

2 Likes
Attempting to access a non preloaded custom field
The software powering this discussion forum encountered an unexpected problem
(Tobias Eigen) #427

I had the same experience. Removing from app.yml and rebuilding was the fix for me.

2 Likes
#428

That’s something you can somewhat do by putting the events in different categories. The event would have the category color on the main agenda, and you can filter the events by filtering the categories.

I think adding a feature as you are describing should be done with icons rather than colors, maybe with tags (adding an icon if the event has that specific tag). Ideally it would be out-of-the-box with the tag icon theme component.

1 Like
(Carson) #429

It works beautifully… thanks for this tip. I wonder if there is a way to also filter events by tags? As it is, though, this is quite robust.

(Angus McLeod) #430

@hellekin @tobiaseigen I just pushed an update to fix this issue.

3 Likes
#432

That would indeed be super useful !

If there is a way to just use the usual thunderbird or other calendars with a login/pass, that would be very handy !

3 Likes
(Danny Goodall) #433

Hi @angus, I’ve found what looks like a bug. I’m not sure if it stems from the Events Plugin or core.

It comes from my specific use-case and the way I’m using the plugin so I’m not sure how widespread this will be amongst your users.

When you visit the unadorned category URL of a category that is set to display the Agenda you are no longer redirected to the route that you use in the Events Plugin.

For example, if I have a category a-category and my category settings state that my Default Topic List is set to Agenda, and I visit the base URL for that category…

/c/a-category

I am no longer redirected to…

/c/a-category/l/agenda

…as I used to be.

Instead, I am given a blank browser page and the console reports the following error.

Detailed log from Chome console

_ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3841 Uncaught t {stack: “Error: Can’t trigger action ‘refreshTitle’ because…61e7351258de8d2e886bf2ce86f144368848.js:16:22294)”, description: undefined, fileName: undefined, lineNumber: undefined, message: “Can’t trigger action ‘refreshTitle’ because your a…ssed to the model/beforeModel/afterModel hooks.”, …}code: undefineddescription: undefinedfileName: undefinedlineNumber: undefinedmessage: "Can’t trigger action ‘refreshTitle’ because your app hasn’t finished transitioning into its first route. To trigger an action on destination routes during a transition, you can call .send() on the Transition object passed to the model/beforeModel/afterModel hooks."name: "Error"number: undefinedstack: "Error: Can’t trigger action ‘refreshTitle’ because your app hasn’t finished transitioning into its first route. To trigger an action on destination routes during a transition, you can call .send() on the Transition object passed to the model/beforeModel/afterModel hooks.↵ at new t (https://beta.my.site/assets/ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:11:25040)↵ at n.T (https://beta.my.site/assets/ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:8:18150)↵ at u.triggerEvent (https://beta.my.site/assets/ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:8:22657)↵ at u.e.trigger (https://beta.my.site/assets/ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:18:12495)↵ at n.o.send (https://beta.my.site/assets/ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:8:26946)↵ at n. (https://beta.my.site/assets/application-027cbafa61f4cc1b5b55a63ba2b79d91c9311e929214519811bf586ae80581c9.js:13:16507)↵ at b (https://beta.my.site/assets/ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:6:19364)↵ at n.trigger (https://beta.my.site/assets/ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:9:23249)↵ at https://beta.my.site/assets/ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:8:22830↵ at e.invoke (https://beta.my.site/assets/ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:16:22294)"proto: Error
(anonymous) @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3841
setTimeout (async)
we.readyException @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3840
(anonymous) @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3860
p @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3548
h @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3616
setTimeout (async)
(anonymous) @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3654
c @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3282
fireWith @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3412
fire @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3420
c @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3282
fireWith @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3412
h @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3636
setTimeout (async)
(anonymous) @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3654
c @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3282
fireWith @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3412
fire @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3420
c @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3282
fireWith @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3412
ready @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3892
h @ _ember_jquery-5dbd79abddf53926275c73f77dbe61e7351258de8d2e886bf2ce86f144368848.js:3902

if I try to visit the full URL /c/a-category/l/agenda then it works as expected.

This is a change in behaviour between beta5 and beta7+7 (I just upgraded my test instance to beta7+7 and now I see this behaviour).

I am using your Custom Wizard Plugin redirect feature to redirect to this category which is why I mention my specific use case. I guess I can just change my code to append /l/agenda/ to get this working, but wanted to know if this is expected behaviour.

Finally, and oddly, if I locate the category in question in the category list from the home page and I hover over it with the mouse, I see that the URL it will take me to is in fact the unadorned version - i.e. /c/a-category.

However, when I click it, it works as expected and takes me to the /c/a-category/l/agenda page. If, instead of clicking the URL I copy the URL and paste it in to the browser, it fails as I described above. Some clever internal JavaScript redirection going on I guess?

I’m running 2.3.0 beta7+7 and the latest Events Plugin and am testing in Chrome Version 72.0.3626.96 (Official Build) (64-bit) on Ubuntu.

I’ve tried to repro on your sandbox but couldn’t find a category that is set to display the Agenda as the Default Topic List.

2 Likes
(Angus McLeod) #434

Thanks for a great bug report! I can indeed repro it on my sandbox, e.g.

https://discourse.angusmcleod.com.au/c/work

This week is very busy, so I’m going to have to look at this next week:

https://discourse.angusmcleod.com.au/t/events-naked-url-redirect-issue/856

3 Likes
(Tobias Eigen) #435

Can we also add event rsvp improvements to your agenda? We are increasingly wanting to find alternatives to GoToWebinar for handling events, and this would be ideal. :rocket:

(Angus McLeod) #436

There’s one on Events agenda: Events: Add admin controls for RSVP list - Public Work - Angus' Sandbox. Let me know specifically what else is needed.

This is now fixed. Turned out to be a bit of a hairy issue.


In other news, subscribing to calendar feeds of private categories is now supported. You have to add an appropriate api_key and api_username as query params to get it to work. For example:

webcal://discourse.angusmcleod.com.au/calendar.ics?time_zone=Australia/Melbourne&api_key={your_api_key}&api_username={your_username}
4 Likes
(Tobias Eigen) #437

Cool! That feature would be great and would go a long way to helping us. :rocket:

The task list you wrote above contained most the features I think we need. To repeat the key ones from there that would make this plugin work as eventbrite killer:

  • Guest rsvp
  • Event reminders
  • Event rsvp list export
  • Rsvp custom fields

Other items from your list that are interesting for this purpose:

  • Adding multiple events to one topic.
  • Recurring events

There are more items on that list where I am not sure of the status and would be glad of an update.

I’d be happy to review this topic for feature suggestions and update the OP with a proposed task list if you like, as I did for the ticket plugin. Let me know.

2 Likes
(Angus McLeod) #438

Cool, thanks. I’ve slotted in Guest RSVP, and moved Admin controls for RSVP list, which includes list export, up the agenda.

https://discourse.angusmcleod.com.au/t/events-add-admin-controls-for-rsvp-list/840

Multiple and recurring events are tricker / hairier, so I’ll take a look at them again in May, but can’t make any promises in that respect

https://discourse.angusmcleod.com.au/t/events-recurring-and-or-multiple-events/841/2

I’ll also take a look at event reminders in May

https://discourse.angusmcleod.com.au/t/add-event-reminders/879

RSVP custom fields will have to wait till June.

https://discourse.angusmcleod.com.au/t/add-rsvp-custom-fields/880

2 Likes
(Marcin Faszczewski) #439

Hi everyone! Hi @angus!
Great plugin! Thanks a lot!

I think i found some issue. While approval post from “Needs Review” the date and time of event are lost.
image

While approval isn’t any information about date and time.

While editing post pending isn’t any information about date and time.

And after approval or save the date and time of event are lost. Have you some solution of that or maybe I’m doing something wrong?

(Tobias Eigen) #440

Hi Marcin! Thanks for the detailed report.

I didn’t even realize you can edit posts via the review queue - that’s pretty cool!

Are you sure the event details are lost when approving posts? Or is it just not showing up there?

Generally, my thinking is that the events plugin is separate from the (very new) review queue functionality. The events plugin is not an official plugin and it is not integrated with other functionality, and so I don’t expect it to be. I’m not sure it really matters that you can’t see and edit event details via the review queue. You want to use the forum to read and manage discussions in any case, where you can always edit event details.

That said, if Angus is easily able to have the event details and edit modal show up in the review queue I can see how that can be useful. Not sure it’s a high priority, though, given his limited time and the other feature development on his task list. :sunny:

1 Like
#441

I found an issue with the events plugin that only manifests if the following conditions are met:

  • Category settings
    • Navigate to first post after topics are read
    • Allow events to be added to topics in this category (overrides site setting).
  • Event type
    • Event is NOT an all day event

When all three are met, the topic doesn’t honour the ‘Navigate to first post’ any more. Other topics (without events or with all day events) in the same category work as expected.

Steps to repro:

  • configure category as described above
  • create new topic
  • add event date and time, do NOT set it to all day event
  • add few posts
  • return to category page, check that the topic is marked as read
  • click on topic title
  • last post is displayed (instead of the first one)

If event is removed or event duration is set to all day, the correct post (first) is displayed.

(Angus McLeod) #442

Great report, however I can’t repro this. I made an example topic in Events - Angus' Sandbox following your suggested steps. The “Navigate to first post after topics are read” setting works as normal.

See if you can reproduce it in that category? It has “Navigate to first post after topics are read” enabled.

2 Likes
#443

Found it! :smile:

The date part of the title—the one that the event plugin appends to it—causes the issue (repro on your sandbox).

  • Clicking on the regular part of the topic title opens the first post
  • Clicking on the date part of the title opens the last post read.
2 Likes
(Angus McLeod) #444

Good catch! I took a quick look, but it’s actually a bit tricky. I’ll need to take a look at this one in some more depth the week after next.

https://discourse.angusmcleod.com.au/t/events-event-label-in-topic-list-does-not-respect-navigate-to-first-post-after-topics-are-read/901

1 Like
(Angus McLeod) #445

As scheduled, I’ve added the ability for event admins to add and remove users from an RSVP list:

2 Likes
(Tobias Eigen) #446

Wow, Angus, this is amazing progress. Thanks!

Three bits of feedback:

  • the “Guest list” entry box is a bit confusing as an empty rectangle to start with - any way you could provide “add a user” helper text in the box to explain what can be done with it, like with starting a new message:
    24%20AM
  • any way to be able to add email addresses to the field, creating a staged user, similar to the PM to staged user functionality?
  • are people on the guest list subscribed to the topic, e.g. are they watching the topic and notified of all replies because they rsvp’d?

And a bug: there seems to be a problem with Guest list being available to be filled in already while the topic is first being created. see screenshot for what happens. If I empty the “Guest list” box and save the topic, then return to edit and add users it works as expected.

14%20AM