Expanding quote that doesn't exist silently fails


(Michael Brown) #1

Continuing the discussion from Libelous quote-to-reply:

Trying to expand a quote referencing a post that doesn’t exist (or referencing NO posts) results in:

and this XHR failure:

We could handle this a little better - perhaps replace “Loading…” with a large blinking :x: and scrolling text that says “REFERENCED POST NOT FOUND”.

I also happened to notice - going to Discourse Meta just results in a totally blank page (with Discourse loaded):


(Robin Ward) #2

I have a fix for this. If a quote has no post associated with it, the controls are not included.

https://github.com/discourse/discourse/commit/b91c70cac32ae00990106892a0e322920b72cab1


(Jeff Atwood) #3