I think we should whitelist Chrome now … hold off on whitelisting Firefox till this is done:
Ok @falco can you do the needful on whitelist? We already whitelist Chrome / Android as I recall.
When it comes to features, Edge has the one critical item that always kept me crawling back to Chrome. If you are on a webpage, you can easily turn it into an app, by clicking the three dots in the top right and clicking install app. This is huge, as it allows me to turn Google Calendar, Tweetdeck, and a few other pages into applications on my desktop that makes my workflow, a lot easier.
we should definitely whitelist all Chrome based browsers @falco
Looks like Chrome Canary is experimenting with a more in your face install button:
Here is it in Meta when the service worker is working:
Niiiice. We should definitely get this working on Chrome. I like it.
We want to get this working, but the last time we tried with the “You are offline” page wasn’t a great experience. Also we had a lot of suggestions about making reading Discourse possible when you are offline.
Remove the “You are offline” page
Make Discourse fallback to cache when a network request fail aka Discourse will allow offline browsing of every previously visited page.
Get a perfect score in the PWA Lighthouse audit:
Get the “Install Site” on the Desktop working (availiable in Chrome canary for now, will land in stable around August)
The changes are pending in this branch: Comparing master...offline · discourse/discourse · GitHub
A demo site is running at https://discourse-workbox.muito.ninja/
Here is a demo of Discourse offline browsing on iPad
Can you create topics offline that get synced with the server when the device is back online?
The current changes only affect
GET requests, so it will make you able to use the composer, if you ever did it while online.
Discourse already keeps submitting a topic in a persistent “Saving” blue bar, and this doesn’t touch that request, so it should keep the current behavior.
However, getting Discourse to work totally in write mode while offline would require a lot more work and be a long term project involving multiple people. That is not the scope here, which is just enabling installs in Desktop.
In Chrome 76, we’re making it easier for users to install Progressive Web Apps on the desktop by adding an install button to the omnibox.
Okay, this is live in Meta for testing now. Please report any crazyness.
Here is Meta install:
Is there a flag we can set to tinker with this on our own installations?
It’s in the same branch as always here. You could deploy from that branch but it is a lot behind master currently. I can rebase it to master, but I don’t recommend messing with this until it’s proven stable here.
Another cool thing, if you try to use the pwa with a cold cache:
This is live on latest Discourse
Please report any #bug in new topics.
Chrome 76 was launched yesterday with the Install call to action in the omnibar, and latest Discourse works with it out of the box.
Confirmed working in Chrome 76 released today, there’s even a fairly complex animation in the address bar which calls attention to it.
Looks like the animation only happens once per domain though.
This is technically shipped but I still view it as rather experimental so I am re-opening the topic.
Is there a way to dismiss the icon in the address bar, either from Discourse or from Chrome? I prefer to just use the browser, so I don’t see the point in having that icon visible forever.
Probably a question better directed towards the Chrome browser developers, not us.
I’ve been googling around on the Chrome side, but couldn’t find anything. So I guess I’ll ask them.
Is this something that could theoretically be dismissable (e.g. with localstorage) or hidden permanently based on a Discourse setting? I’m asking because I don’t know if Chrome automatically detects if the website is compatible as a PWA or if there’s some flexibility on your end to only offer the option conditionally.
For anyone else interested, there’s a setting in
App Banners which you can set to
Disabled to remove the icon in the address bar.
EDIT: Actually, the relevant setting seems to be
Desktop PWAs installable from the omnibox.