"FAILED" error selecting Favorite badges

andrei · July 14, 2021, 3:18pm

This PR fixes problems with selecting favorite badges:

github.com/discourse/discourse

FIX: problems with choosing favorite badges

discourse:master ← discourse:fix/favorite-badges-problem

opened 02:45PM - 14 Jul 21 UTC

AndrewPrigorshnev

+16 -1

Choosing favorite badges started [behaving strange](https://meta.discourse.org/t…/failed-error-selecting-favorite-badges/195657) recently. This PR fixes the problem. I'm a bit concerned about API method, and I'd like to change it in subsequent PR if there are no objections. We have this method: ``` PUT user_badges/20/toggle_favorite ``` And here is JSON this method returns: <img width="400" alt="Screenshot 2021-07-14 at 16 54 19" src="https://user-images.githubusercontent.com/1274517/125640390-0be207d6-9844-4dd9-ac75-6e12d262d7d8.png"> It's quite a lot. In fact, this method could be returning only status code. That would be enough to figure out everything on the client side. No need to serialize objects, no need to send them to the client. It'll be a bit more efficient, but I'm also concerned about clearness of API. Looks like there's no need to return anything from this method. Even more, instead of `toggle_favorite` it can be an idempotent method that sets `is_favorite` to provided value, and returns only status code as well ``` PUT user_badges/20/favorite { true } or PUT user_badges/20/favorite { false } ```

Topic		Replies	Views
Since 2.8.0beta2 update some users can't get to preferences (etc) support	8	564	July 16, 2021
Like button does not work on archived topics bug reactions	24	1075	August 23, 2022
Quick access to bookmarks and messages on user menu feature	57	5809	November 3, 2020
Badge DB seed is broken bug	8	705	January 27, 2019
Error rebuilding due to old tagging plugin installation	3	632	May 21, 2021

"FAILED" error selecting Favorite badges

Related Topics