Fallback for `user_in_X` theme setting support fails when resolved value is false

Oh thanks for raising this, I’ve just made a dumb mistake in the theme component. This:

if (settings.user_in_copy_button_allowed_groups) {
  return true;
}

Should be:

return settings.user_in_copy_button_allowed_groups;

The fallback should only happen when Object.hasOwn(settings, "user_in_copy_button_allowed_groups") is false. Will go fix these components I added this stuff to…

3 Likes