Feedback on admin sidebar when header dropdown navigation selected

martin · May 28, 2024, 1:18am

Okay the fix is here, I will merge it as soon as I can:

github.com/discourse/discourse

FIX: Admin sidebar disappeared on some routes for header dropdown

discourse:main ← discourse:issue/admin-sidebar-header-dropdown-compat

opened 01:17AM - 28 May 24 UTC

martin-brennan

+10 -1

When navigation_menu is set to header dropdown, we are still forcing admin side…bar by checking if the user is an admin route (c.f. 9bcbfbba43b876ae92cb90d6d619be7b1154c119). However in the initial commit the route check had the false premise that all admin routes started with `admin.`; there are others that don't. We need to force admin sidebar on all routes starting with `admin` (no `.`). c.f. https://meta.discourse.org/t/feedback-on-admin-sidebar-when-header-dropdown-navigation-selected/309490/3?u=martin

Topic		Replies	Views
Introducing admin sidebar navigation Announcements feedback , admin-sidebar	109	6490	May 12, 2025
Removing the legacy hamburger navigation menu option Announcements	44	4346	May 12, 2025
Try out the new sidebar and notification menus! Announcements notifications , sidebar , new-feature	221	20281	October 19, 2022
Feedback on new :hamburger: and user menus UX	231	25845	July 15, 2016
I dislike the new mobile topic header behavior in 2.2.0.beta5 UX	100	6902	January 8, 2019

Feedback on admin sidebar when header dropdown navigation selected

Related topics