Files with weird permissions in the git repository


(Darix) #1

While upgrading my discourse rpm to beta7 i wanted to clean up my rpmlint warnings.

All those files have the x bit set but lack a shebang line. Do they need to be executable?

test/javascripts/mdtest/fixtures/Inline HTML (Advanced).text
test/javascripts/mdtest/fixtures/Inline HTML (Simple).xhtml
test/javascripts/mdtest/fixtures/Inline HTML comments.text
test/javascripts/mdtest/fixtures/Markdown Documentation - Basics.text
test/javascripts/mdtest/fixtures/Inline HTML (Simple).text
test/javascripts/mdtest/fixtures/Markdown Documentation - Syntax.text
test/javascripts/mdtest/fixtures/Links, shortcut references.text
test/javascripts/mdtest/fixtures/Images.xhtml
test/javascripts/mdtest/fixtures/Literal quotes in titles.xhtml
test/javascripts/mdtest/fixtures/Tidyness.text
test/javascripts/mdtest/fixtures/Blockquotes with code blocks.text
test/javascripts/mdtest/fixtures/Ordered and unordered lists.text
test/javascripts/mdtest/fixtures/Links, shortcut references.xhtml
test/javascripts/mdtest/fixtures/Code Spans.xhtml
test/javascripts/mdtest/fixtures/Backslash escapes.xhtml
test/javascripts/mdtest/fixtures/Ordered and unordered lists.xhtml
test/javascripts/mdtest/fixtures/Images.text
test/javascripts/mdtest/fixtures/Links, reference style.text
test/javascripts/mdtest/fixtures/Markdown Documentation - Syntax.xhtml
lib/common_passwords/10k-common-passwords.txt
test/javascripts/mdtest/fixtures/Blockquotes with code blocks.xhtml
test/javascripts/mdtest/fixtures/Links, inline style.text
test/javascripts/mdtest/fixtures/Tidyness.xhtml
test/javascripts/mdtest/fixtures/Inline HTML (Advanced).xhtml
test/javascripts/mdtest/fixtures/Auto links.xhtml
test/javascripts/mdtest/fixtures/Markdown Documentation - Basics.xhtml
test/javascripts/mdtest/fixtures/Inline HTML comments.xhtml
test/javascripts/mdtest/fixtures/Hard-wrapped paragraphs with list-like lines.text
test/javascripts/mdtest/fixtures/Hard-wrapped paragraphs with list-like lines.xhtml
test/javascripts/mdtest/fixtures/Backslash escapes.text
test/javascripts/mdtest/fixtures/Literal quotes in titles.text
test/javascripts/mdtest/fixtures/Nested blockquotes.xhtml
test/javascripts/mdtest/fixtures/Tabs.text
test/javascripts/mdtest/fixtures/Code Spans.text
test/javascripts/mdtest/fixtures/Amps and angle encoding.text
test/javascripts/mdtest/fixtures/Links, reference style.xhtml
test/javascripts/mdtest/fixtures/Strong and em together.text
test/javascripts/mdtest/fixtures/Horizontal rules.xhtml
test/javascripts/mdtest/fixtures/Code Blocks.xhtml
test/javascripts/mdtest/fixtures/Horizontal rules.text
test/javascripts/mdtest/fixtures/Links, inline style.xhtml
test/javascripts/mdtest/fixtures/Strong and em together.xhtml
test/javascripts/mdtest/fixtures/Tabs.xhtml
test/javascripts/mdtest/fixtures/Amps and angle encoding.xhtml
test/javascripts/mdtest/fixtures/Code Blocks.text
test/javascripts/mdtest/fixtures/Auto links.text
test/javascripts/mdtest/fixtures/Nested blockquotes.text

Those files have a shebang line but are not marked as executable:

config/cloud/cloud66/scripts/drop_create.sh 0640L /bin/bash
script/memstats.rb 0640L /usr/bin/env
script/version_bump.rb 0640L /usr/bin/env
vendor/gems/rails_multisite/Rakefile 0640L /usr/bin/env
script/test_email_settings.rb 0640L /usr/bin/env
vendor/gems/discourse_imgur/Rakefile 0640L /usr/bin/env
Rakefile 0640L /usr/bin/env
config/cloud/cloud66/scripts/permissions.sh 0640L /bin/bash
config/cloud/cloud66/scripts/migrate.sh 0640L /bin/bash
config/cloud/cloud66/scripts/import_prod.sh 0640L /bin/bash
config/cloud/cloud66/scripts/curl.sh 0640L /bin/bash
config/cloud/cloud66/scripts/env_vars.sh 0640L /bin/bash
config/cloud/cloud66/scripts/import_dev.sh 0640L /bin/bash
config/cloud/cloud66/scripts/kill_db.sh 0640L /bin/bash
```

(Darix) #2

should I just do a pull request with the permission fixes?


(Sam Saffron) #3

Sure, go for it


(Darix) #4

https://github.com/discourse/discourse/pull/3457