Fix Rake command, whitelist pcpartpicker.com in discourse/Onebox


#1

I really don’t know if we should use the dev category at meta or the github issues.
Only thread I found is from 2013.

Anyway, I fixed the rake issue with my pull request.

https://github.com/discourse/onebox/issues/250
https://github.com/discourse/onebox/pull/249


(Sam Saffron) #2

I left this on the PR, I am concerned white list is getting too long and full of edge case sites.

I wonder if instead we should invest more effort in allowing sites to automatically detect candidates.

cc @codinghorror


(Jeff Atwood) #3

They already have the ability to whitelist sites in site settings for one boxing, not sure what you are referring to?


#4

Wow sorry, after googling for this I could only find

Thanks though. :slight_smile: :wink:


(Jeff Atwood) #5

(Sam Saffron) #6

sorry, I mean

  • if we detect that say 10 users tried to onebox site X
  • it has opengraph
  • we notify moderator “looks like lots of users are trying to onebox X would you like to add to whitelist”

(Jeff Atwood) #7

Sure but that should be a feature req not buried here in a random dev topic.