لقد قمت بإنشاء طلب سحب (PR) لملء أيقونات FA المفقودة. ومع ذلك، لا تزال تفتقد أيقونات SVG المخصصة الإضافية الخاصة بـ Discourse. سيتم ترك هذا لطلب سحب آخر.
main ← Arkshine:fix-missing-icon
opened 06:53PM - 16 May 25 UTC
Meta: https://meta.discourse.org/t/fontawesome-pro-plugin-not-changing-all-defau… lt-icons/365953
This PR updates the icons list to match core.
- `fab-` icons are ignored since no equivalent exists to the other styles.
- `discourse-` [additional icons](https://github.com/discourse/discourse/blob/main/vendor/assets/svg-icons/discourse-additional.svg?short_path=dece804) are ignored for now. That would require making custom SVGs for solid, thin, and dual-tone. That would be another PR.
- Some of the replacements (from [here](https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/lib/icon-library.js)) are ignored since they're associated with `discourse-` icons. I'm unsure if icons like heart should be replaced, in the context where it makes sense to see them filled.
It also adds a `fa_icon-enabled` setting so we can access the `Settings` button on the plugins page.
3 إعجابات