Forcing email context

email

(James Milligan) #1

Thought I’d dive straight into Ruby for the first time and have a crack at implementing a feature me and some others would like to see in Discourse, a user option to force context in notification emails.

I’ve added the user option, that persists and is working fine.

I’ve modified a unit test to include a new parameter that I’ve added, that passes the same as it did before.

I’ve added a unit test to cater for the new parameter being set to true, that passes fine.

However, it doesn’t work on my development system. The emails in mailcatcher still only have the latest reply in there, even when another ‘user’ has replied.

Any hints for where to look next?

Here’s a diff up on Pastebin: http://pastebin.com/sqBxMQfc


(James Milligan) #2

Actually, it worked all along… I just did a full reboot of everything, and gave it another shot, and the emails are now coming through as expected.

Creating my first pull request now!

EDIT:


(Allen - Watchman Monitoring) #3

I’d love to see this… but as a site-wide option, it’s especially useful when people post on old topics.


(Sam Saffron) #4

Completed via:


(Jeff Atwood) #5