Steven
29 نوفمبر 2018، 12:07ص
108
New version available, I fixed the incompatibility of some icons with the latest version of Discourse (that includes FontAwesome 5).
It was easier that I thought, but if you have any issue, let me know
I also changed the icon of the color’s button : instead of the paint brush, we will use the palette. Here are all the icons available:
I think it suits the button better.
If you have a fork on this plugin with custom buttons, the update is pretty easy, you just have to edit your plugin.rb file (example : line 20 to 27 : discourse-formatting-toolbar/plugin.rb at master · MonDiscourse/discourse-formatting-toolbar · GitHub )
You have to register any icon you use. Search for your icon here : Find Icons with the Perfect Look & Feel | Font Awesome
If the icon is in ‘solid’ category, add :
register_svg_icon "fa-icon_name" if respond_to?(:register_svg_icon)
ex : register_svg_icon "fa-underline" if respond_to?(:register_svg_icon)
If the icon is in ‘regular’ category, add
register_svg_icon "far-icon_name" if respond_to?(:register_svg_icon)
ex : register_svg_icon "far-address-book" if respond_to?(:register_svg_icon)
If the icon is in ‘brand’ category, add
register_svg_icon "fab-icon_name" if respond_to?(:register_svg_icon)
ex : register_svg_icon "fab-apple" if respond_to?(:register_svg_icon)
8 إعجابات
AndreaG
(Andrea Genini)
3 يناير 2019، 8:12م
109
I just installed the plugin on the v2.2.0.beta7 and i have a problem: line spacing between paragraphs collapse when using text formatting: [right], [left], [center], [justify]
See the following example:
The preview on the right window is correct. But then… see next post
إعجاب واحد (1)
AndreaG
(Andrea Genini)
3 يناير 2019، 8:13م
110
After Reply, the text appear correctly first, but after 1-2 seconds the line spacing between the two paragraphs collapses.
إعجاب واحد (1)
Steven
3 يناير 2019، 9:30م
111
Thanks for the feedback, I pushed a fix. Let me know if it works well
For the previous posts, you might need to do a Rebuild HTML to update the code.
إعجاب واحد (1)
AndreaG
(Andrea Genini)
3 يناير 2019، 9:40م
112
Hi Steven.
No, it doesn’t work. After rebuilding HTML line spacing disappears after a fraction of a second.
AndreaG
(Andrea Genini)
3 يناير 2019، 10:13م
113
My fault! After rebuilding app it works. Thank you Steven.
I love this plugin.
إعجاب واحد (1)
AndreaG
(Andrea Genini)
20 يناير 2019، 2:54م
114
I found another bug. After justifying the text there is an additional line spacing. I’m working with V2.2.0.beta8.
Steven
20 يناير 2019، 3:57م
115
The behaviour is different from the preview and the cooked post (on preview, it adds the <p>
tags for each bbcodes, not on cooked), I don’t really know where it comes from, I don’t know if it’s something I can fix on my part
edit : wait I have an idea, I can fix it in a few hours
AndreaG
(Andrea Genini)
20 يناير 2019، 4:40م
116
Hi Steven, if I put only one [right]
in the first line and a [/right]
at the end of the last line, it works correctly.
إعجاب واحد (1)
Steven
20 يناير 2019، 5:06م
117
I did a little upgrade to prevent this different behaviour between preview and cooked post. I should have thought about that before
I’ll check the source of the bbcodes later, maybe I can do something better than a css fix, but it should be good for now
Thanks for your feedbacks
إعجاب واحد (1)
how is it recommended to clear a left or right float?
“clear:both;” in a div tag does not seem to work
Also any advice on floating or centering a youtube embed?
Steven
3 سبتمبر 2019، 7:50م
119
I can create a clear bbcode, I did it on a customized version of this plugin, I will add it to the official.
It will be [floatc][/floatc]
, with a clear: both css code attached to it
edit :
https://github.com/iunctis/discourse-formatting-toolbar/commit/b52c9c4312d869edb33390eea8b7027a4127504a
Regarding the youtube embed, You can try add a line between the bbcodes and the link
It should work on preview and cooked post
إعجاب واحد (1)
Steven
11 سبتمبر 2019، 9:00م
121
I don’t exactly see the issue, can you clarify a little please
Bank_Live
(Bank Live)
13 سبتمبر 2019، 4:47ص
122
I mean tools post outsite.
إعجاب واحد (1)
Steven
13 سبتمبر 2019، 8:05م
123
edit : Oh I see what’s wrong, I’ll fix it immediately, check the updates @Bank_Live
I need to edit the css that cause this issue.
edit : It is fixed now, thanks for reporting!
إعجاب واحد (1)
xiasummer
(xiasummer)
27 سبتمبر 2019، 10:45ص
124
Seems
discourse-formatting-toolbar
is not working now.
I’ve installed it, and I’ve started it, but nothing happened. Refreshing the webpage, still nothing happened. I’ve activated the color buttom, but nothing happened.
إعجاب واحد (1)
Steven
27 سبتمبر 2019، 12:40م
125
What Discourse version are you on?
I’ll check asap, but there doesn’t seem to be a commit on Discourse that could break the plugin
إعجاب واحد (1)
Steven
27 سبتمبر 2019، 7:17م
126
I just checked, no issue here
What plugin do you have ?
Are you adding a hexadecimal color code on the bbcode? Ex: [color=#ff3300]Text[/color]
إعجاب واحد (1)
xiasummer
(xiasummer)
29 سبتمبر 2019، 2:43ص
127
installed
2.4.0.beta4
(8adec48b33 )
Strange, the formatting tool bar is not activated seems,
But, I should have activated it