# Обнаружена неиспользуемая переменная \`expires\` в lib/secure\_session.rb, похоже, это ошибка

**URL:** https://meta.discourse.org/t/found-unused-variable-expires-at-lib-secure-session-rb-it-seem-like-a-mistake/133027
**Category:** Development
**Created:** [10.Ноябрь.2019 06:48:21 UTC](https://meta.discourse.org/t/found-unused-variable-expires-at-lib-secure-session-rb-it-seem-like-a-mistake/133027 "2019-11-10T06:48:21Z")
**Posts on this page:** 4
**Page:** 1

<div class="post-metadata">

### Author: ![coocooooo](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/coocooooo/32/158982_2.png) [@coocooooo](https://meta.discourse.org/u/coocooooo)
#### Post date: [10.Ноябрь.2019 06:48:21 UTC](https://meta.discourse.org/t/found-unused-variable-expires-at-lib-secure-session-rb-it-seem-like-a-mistake/133027/1 "2019-11-10T06:48:21Z")

</div>

Обнаружена неиспользуемая переменная `expires` в файле lib/secure\_session.rb, похоже, это ошибка

> <https://github.com/discourse/discourse/blob/15f6f57cdcebc7583ddb5a311174d10a7300ae4a/lib/secure_session.rb#L18>

```rb
def set(key, val, expires: nil)
    expires ||= SecureSession.expiry
    $redis.setex(prefixed_key(key), SecureSession.expiry.to_i, val.to_s)
    true
  end

```

---

<div class="post-metadata">

### Author: ![gerhard](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/gerhard/32/119479_2.png) [@gerhard](https://meta.discourse.org/u/gerhard)
#### Post date: [10.Ноябрь.2019 13:19:11 UTC](https://meta.discourse.org/t/found-unused-variable-expires-at-lib-secure-session-rb-it-seem-like-a-mistake/133027/2 "2019-11-10T13:19:11Z")

</div>

@sam, не должно ли это быть `$redis.setex(prefixed_key(key), expires.to_i, val.to_s)`? Похоже, что тесты не падают, потому что они используют значение по умолчанию — 1 час.

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [11.Ноябрь.2019 00:22:49 UTC](https://meta.discourse.org/t/found-unused-variable-expires-at-lib-secure-session-rb-it-seem-like-a-mistake/133027/3 "2019-11-11T00:22:49Z")

</div>

Хорошо подмечено, да, @gerhard, звучит правильно, исправлено. Отличное замечание, @coocooooo.

> <https://github.com/discourse/discourse/commit/91daafc674a90221b355eb1930c1f47df2658cc9>
>
> Previously we were always hard-coding expiry, this allows the secure session
> to …correctly handle custom expiry times
> 
> Also adds a ttl method for looking up time to live

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [11.Ноябрь.2019 07:21:23 UTC](https://meta.discourse.org/t/found-unused-variable-expires-at-lib-secure-session-rb-it-seem-like-a-mistake/133027/4 "2019-11-11T07:21:23Z")

</div>