found unused variable expires at lib/secure_session.rb, it seem like a mistake https://github.com/discourse/discourse/blob/15f6f57cdcebc7583ddb5a311174d10a7300ae4a/lib/secure_session.rb#L18 def set(key, val, expires: nil) expires ||= SecureSession.expiry $redis.setex(prefixed_key(key), Sec…

Found unused variable `expires` at lib/secure_session.rb, it seem like a mistake

sam (Sam Saffron) November 11, 2019, 12:22am 3

Nice catch, yeah @gerhard that sounds right, fixed. Nice catch @coocooooo

2 Likes

Topic		Replies	Views
"User requested shutdown" every time I run `./launcher rebuild app` although I never request shutdown installation	2	578	July 24, 2019
I'm running into this error installation	6	490	May 23, 2023
A more efficient Redis lock dev	1	660	January 31, 2021
Is there a way to set session expiration after a set length of time? feature	23	7420	April 5, 2017
Rebuild failure: "extconf failed, exit code 1" -- due to old Docker? installation	11	1034	February 21, 2024