# German umlauts are NOT handled correct for Badges

**URL:** https://meta.discourse.org/t/german-umlauts-are-not-handled-correct-for-badges/31675
**Category:** Feature
**Created:** [8월 2, 2015, 11:35오후 UTC](https://meta.discourse.org/t/german-umlauts-are-not-handled-correct-for-badges/31675 "2015-08-02T23:35:44Z")
**Posts on this page:** 8
**Page:** 1

<div class="post-metadata">

### Author: ![ndalliard](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/ndalliard/32/44338_2.png) [@ndalliard](https://meta.discourse.org/u/ndalliard)
#### Post date: [8월 2, 2015, 11:35오후 UTC](https://meta.discourse.org/t/german-umlauts-are-not-handled-correct-for-badges/31675/1 "2015-08-02T23:35:44Z")

</div>

Continuing the discussion from [Please replace German umlauts in URLs with their respective digraphs](https://meta.discourse.org/t/please-replace-german-umlauts-in-urls-with-their-respective-digraphs/24489/9):

> [@Please replace German umlauts in URLs with their respective digraphs](https://meta.discourse.org/t/please-replace-german-umlauts-in-urls-with-their-respective-digraphs/24489/9):
>
> German umlauts are now handled correctly if the default locale of the forum is “de”:
> 
> [FEATURE: Adds transliteration of German umlauts in slugs · discourse/discourse@8a236c0 · GitHub](https://github.com/discourse/discourse/commit/8a236c06e282e7bc64e2bf963d52ade261755255)

I love this feature a lot, thanks to @gerhard at this point! But (there is always a but…) I just saw, that umlauts aren’t handled correct in the bagde urls. That isn’t a big deal, but I think if we do it, we can do it also for the badges. Don’t know if that is hard to implement. Maybe a feature for some time in the future.

---

<div class="post-metadata">

### Author: ![gerhard](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/gerhard/32/119479_2.png) [@gerhard](https://meta.discourse.org/u/gerhard)
#### Post date: [8월 3, 2015, 8:10오전 UTC](https://meta.discourse.org/t/german-umlauts-are-not-handled-correct-for-badges/31675/2 "2015-08-03T08:10:56Z")

</div>

Thanks for the praise, but (yes, there’s always a “but” ;-)) most of the work was actually done by @fantasticfears.

> [@Removing the concept of "slugs" for some languages](https://meta.discourse.org/t/removing-the-concept-of-slugs-for-some-languages/26643/14):
>
> I am working on it. Maybe I can submit the pr in next 24h. It depends on your judgement about the release date. So it’s your call to consider whether merge it or not. I hope it can catch up 1.3 personally. EDIT: Here it is. [https://github.com/discourse/discourse/pull/3370](https://github.com/discourse/discourse/pull/3370)

---

<div class="post-metadata">

### Author: ![ndalliard](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/ndalliard/32/44338_2.png) [@ndalliard](https://meta.discourse.org/u/ndalliard)
#### Post date: [8월 3, 2015, 8:36오전 UTC](https://meta.discourse.org/t/german-umlauts-are-not-handled-correct-for-badges/31675/3 "2015-08-03T08:36:04Z")

</div>

Thanks for clearing this up @gerhard. We say: “Ehre wem Ehre gebührt.” 🙂 Okay, maybe @fantasticfears will find some spare time to make that Feature perfect. But as I said, it is a small little thing…

---

<div class="post-metadata">

### Author: ![fantasticfears](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/fantasticfears/32/119608_2.png) [@fantasticfears](https://meta.discourse.org/u/fantasticfears)
#### Post date: [8월 4, 2015, 7:20오전 UTC](https://meta.discourse.org/t/german-umlauts-are-not-handled-correct-for-badges/31675/4 "2015-08-04T07:20:58Z")

</div>

Well. My PR is not relevant to language any more.

You can find a setting `slug_genertaion_method` controls the slug things.

Now `ascii` is the default which means we are using Rails default slug generation algorithm. So it’s up to you to update the transliteration rules…

Hope it explains things.

---

<div class="post-metadata">

### Author: ![gerhard](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/gerhard/32/119479_2.png) [@gerhard](https://meta.discourse.org/u/gerhard)
#### Post date: [8월 4, 2015, 7:28오전 UTC](https://meta.discourse.org/t/german-umlauts-are-not-handled-correct-for-badges/31675/5 "2015-08-04T07:28:55Z")

</div>

The German transliteration rules should be fine. I didn’t verify it yet, but I think the problem is that badge URLs do not use the `slug_generation_method`.

---

<div class="post-metadata">

### Author: ![fantasticfears](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/fantasticfears/32/119608_2.png) [@fantasticfears](https://meta.discourse.org/u/fantasticfears)
#### Post date: [8월 4, 2015, 8:14오전 UTC](https://meta.discourse.org/t/german-umlauts-are-not-handled-correct-for-badges/31675/6 "2015-08-04T08:14:38Z")

</div>

Confirmed that.

Badge can be a English name. For the default badges, translation will be used if exists. But it requires you uses the default English badge name.

---

<div class="post-metadata">

### Author: ![gerhard](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/gerhard/32/119479_2.png) [@gerhard](https://meta.discourse.org/u/gerhard)
#### Post date: [9월 19, 2015, 8:51오후 UTC](https://meta.discourse.org/t/german-umlauts-are-not-handled-correct-for-badges/31675/7 "2015-09-19T20:51:14Z")

</div>

I sent a fix for this:  
[https://github.com/discourse/discourse/pull/3791](https://github.com/discourse/discourse/pull/3791)

---

<div class="post-metadata">

### Author: ![zogstrip](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/zogstrip/32/512781_2.png) [@zogstrip](https://meta.discourse.org/u/zogstrip)
#### Post date: [9월 23, 2015, 1:13오후 UTC](https://meta.discourse.org/t/german-umlauts-are-not-handled-correct-for-badges/31675/8 "2015-09-23T13:13:31Z")

</div>


