In this case @davidb @mcwumbly , if the change type was site_setting_default instead of feature for enable_gifs, it wouldn’t have shown the scary permanent message. This is controlled here:
However I do think generally the feature type is fine for this upcoming change…so maybe we need to make this permanent notice something more explicit for upcoming changes.
Maybe will_become_permanent: true or something as extra Metadata? Not sure…