I don’t think so. This case seems similar to image grids. On that change the warning was shown too, but this was the reply I got back then:
1 like
You should still be able to disable it via the normal site setting afterwards.
@davidb can you confirm?
Agree this wording in upcoming changes is something we should also figure out a way to make less confusing.
One thing we can try to do is make that clear in the title and description of the change itself, when it’s configurable.
1 like
The GIFs upcoming change is currently under a hidden site setting but I think going forward we will want to make this visible and can be enabled/disabled within the admin area.
In the meantime just keeping the upcoming change as ‘No one’ and it will be off by default in the future. No need to make any further changes on the admin side.
4 likes
Yes, when I searched for enable_gifs it took me right to the upcoming changes page. It was very confusing.
The concept of the upcoming changes thing is great. Could just use a language tune up.
Thanks all!
2 likes
In this case @davidb @mcwumbly , if the change type was site_setting_default instead of feature for enable_gifs, it wouldn’t have shown the scary permanent message. This is controlled here:
However I do think generally the feature type is fine for this upcoming change…so maybe we need to make this permanent notice something more explicit for upcoming changes.
Maybe will_become_permanent: true or something as extra Metadata? Not sure…