Github Issue Onebox doesn't update the issue status (always open)


#1

https://discourse.syncthing.net/t/syncthing-randomly-removes-all-permissions-from-root-folders/1639/2

While oneboxing it again for example here it gets the correct status, but in the thread itself it has not updated.
https://github.com/syncthing/syncthing/issues/1186

Couldn’t really word the title better, the status is always open as long as you aren’t posting a closed issue (which you probably won’t do at all though)


(Michael Downey) #2

Generally this is by design. See:


(Jeff Atwood) #3

It is bad form for Oneboxes to show transitory data like this anyway.


#4

Couldn’t this specific Onebox use some sort of Github Webhook though?


(Kevin P. Fleming) #5

No, Github webhooks are managed by the repository owners, and they are used to update web services as pushes and other actions occur in the repository. It’s not at all practical to have repository owners install webhooks for every Discourse site that might have onebox links to their issues and pull requests.

A very similar thing will happen if you link to a specific commit in a Github repository, and then that commit is removed. Or if you link to a branch and the branch is removed or renamed. The onebox content is a snapshot from the moment when the post was made, it’s not a live preview of the content at the time the post is read.

I agree with @codinghorror that it’s probably not a good idea to link to transitory content, but even the Discourse developers do it, so maybe something could be done to improve the presentation. Possibly include the date/time that the onebox was captured in its display, so the user can see that it’s not current?


(Michael Downey) #6

This is a great idea!


#7

I hope that I got this fixed with
https://github.com/discourse/onebox/pull/264