# Github onebox does not point to individual commits in PR links

**URL:** https://meta.discourse.org/t/github-onebox-does-not-point-to-individual-commits-in-pr-links/55946
**Category:** Bug
**Created:** [1월 18, 2017, 5:58오전 UTC](https://meta.discourse.org/t/github-onebox-does-not-point-to-individual-commits-in-pr-links/55946 "2017-01-18T05:58:21Z")
**Posts on this page:** 5
**Page:** 1

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [1월 18, 2017, 5:58오전 UTC](https://meta.discourse.org/t/github-onebox-does-not-point-to-individual-commits-in-pr-links/55946/1 "2017-01-18T05:58:21Z")

</div>

`https://github.com/discourse/discourse/pull/4662/commits/706b4f6b9faf1f820a294e83f82b0b5a5dba0475`

[https://github.com/discourse/discourse/pull/4662/commits/706b4f6b9faf1f820a294e83f82b0b5a5dba0475](https://github.com/discourse/discourse/pull/4662/commits/706b4f6b9faf1f820a294e83f82b0b5a5dba0475)

`https://github.com/discourse/discourse/pull/4662`

> <https://github.com/discourse/discourse/pull/4662>

Both links generate the same onebox even though the first link is pointing to a particular commit in the PR.

---

<div class="post-metadata">

### Author: ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [6월 15, 2017, 8:09오후 UTC](https://meta.discourse.org/t/github-onebox-does-not-point-to-individual-commits-in-pr-links/55946/3 "2017-06-15T20:09:50Z")

</div>

It’s because it’s a pull request onebox, not a commit onebox 🙂

I wouldn’t say it’s a bug so much as “we never implemented a different view for the PR onebox if a specific commit is linked to.” I’m not 100% sure what it should show here – the same title but a subtitle with the commit?

---

<div class="post-metadata">

### Author: ![tgxworld](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/tgxworld/32/106117_2.png) [@tgxworld](https://meta.discourse.org/u/tgxworld)
#### Post date: [6월 16, 2017, 12:56오전 UTC](https://meta.discourse.org/t/github-onebox-does-not-point-to-individual-commits-in-pr-links/55946/4 "2017-06-16T00:56:05Z")

</div>

I think it should just use the commit onebox which represents the link better.

---

<div class="post-metadata">

### Author: ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [6월 22, 2017, 7:48오후 UTC](https://meta.discourse.org/t/github-onebox-does-not-point-to-individual-commits-in-pr-links/55946/5 "2017-06-22T19:48:56Z")

</div>

Sure, good suggestion. The latest onebox handles this as a commit onebox:

[https://github.com/discourse/discourse/commit/94ab194a7f420558229f0fb26e790188b629b942](https://github.com/discourse/discourse/commit/94ab194a7f420558229f0fb26e790188b629b942)

---

<div class="post-metadata">

### Author: ![eviltrout](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/eviltrout/32/5275_2.png) [@eviltrout](https://meta.discourse.org/u/eviltrout)
#### Post date: [6월 22, 2017, 7:49오후 UTC](https://meta.discourse.org/t/github-onebox-does-not-point-to-individual-commits-in-pr-links/55946/6 "2017-06-22T19:49:04Z")

</div>


