# Google photos images not downloaded

**URL:** https://meta.discourse.org/t/google-photos-images-not-downloaded/92068
**Category:** Support
**Created:** [11.Июль.2018 09:17:17 UTC](https://meta.discourse.org/t/google-photos-images-not-downloaded/92068 "2018-07-11T09:17:17Z")
**Posts on this page:** 11
**Page:** 1

<div class="post-metadata">

### Author: ![pfaffman](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/pfaffman/32/120154_2.png) [@pfaffman](https://meta.discourse.org/u/pfaffman)
#### Post date: [11.Июль.2018 09:17:17 UTC](https://meta.discourse.org/t/google-photos-images-not-downloaded/92068/1 "2018-07-11T09:17:17Z")

</div>

It seems that Discourse doesn’t see that Google image links are images in order to know to download them locally.

I noticed this first on a multi-site instance, and then checked on try.

Here’s this url `https://photos.app.goo.gl/KXa79xi3R82sjisX8` that renders beautifully into an image, but it never gets pulled down locally. I think it’s because the stupid Google doesn’t make those URLs end in .jpg the way God intended and there’s nothing that can be done, but I thought I’d ask anyway.

[![Google Photos](https://global.discourse-cdn.com/meta/original/4X/a/0/3/a033050697af80ce15f366722647a59bef5756e7.jpeg "New photo · Friday, Jul 6, 2018 📸") ](https://photos.google.com/share/AF1QipM_vKFw26QtLLqV3BHNEe502aUV_f9Hq4KFHzPTEU-lUWF7jV8v0gd0pk5xlZsiNg?key=eFhXWDR3dHE5Vk1ETUdNaWZBT1lOZFU0YmhkX3FB)

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [12.Июль.2018 05:08:15 UTC](https://meta.discourse.org/t/google-photos-images-not-downloaded/92068/3 "2018-07-12T05:08:15Z")

</div>

Interesting … what about flickr?

[![Imgur](https://global.discourse-cdn.com/meta/original/4X/b/0/7/b07df850af8491bc1082d2b4a175fa97924be1bf.jpeg "hamster\_ninja") ](https://www.flickr.com/photos/71459666@N00/24130109/in/photolist-39upZ-764KDt-9x8s8C-38F3n-6RXyP7-dtXsgb-7RuMHf-6P3ubv-7VCArQ-86KvnT-75Nu1a-6PjCap-9467mt-b7smme-9U4hyo-UTybxc-ciZKqS-cN2N2L-7R1VwU-5sNy2b-NAGPU-5nHaHi-mD2Cym-7wCS4D-bWjFot-7qxZhx-75pnnu-fvEZht-5J9PBr-5nMskG-5nfxsR-9rgKnw-3QMfuQ-eNTHnK-5nMsnL-5f3Fwi-8Twkoa-7KTVeS-5nMsj3-5nHbJg-5UsFtC-BPD2R-5nMspN-5PR1np-7uqf47-5pKHU2-7dHyvU-av656a-5nMs1L-6ojLbT)

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [12.Июль.2018 05:12:03 UTC](https://meta.discourse.org/t/google-photos-images-not-downloaded/92068/4 "2018-07-12T05:12:03Z")

</div>

I think this is not specific to google, its more of an all onebox thing, @techAPJ any idea why this is happening.

Also … behold my ninja hamster above, so cute, yet so dangerous.

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [12.Июль.2018 05:57:03 UTC](https://meta.discourse.org/t/google-photos-images-not-downloaded/92068/6 "2018-07-12T05:57:03Z")

</div>

Kind of a scope creep, let’s focus on other things for now. It’s been this way forever.

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [12.Июль.2018 05:58:56 UTC](https://meta.discourse.org/t/google-photos-images-not-downloaded/92068/7 "2018-07-12T05:58:56Z")

</div>

Yeah I remember this popping up before, I am just a bit surprised cause I thought @vinothkannans fixed this a while back.

[https://meta.discourse.org/t/download-images-for-oneboxes-as-well-if-download-images-is-set/21103/30?u=sam](https://meta.discourse.org/t/download-images-for-oneboxes-as-well-if-download-images-is-set/21103/30)

---

<div class="post-metadata">

### Author: ![codinghorror](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/codinghorror/32/110067_2.png) [@codinghorror](https://meta.discourse.org/u/codinghorror)
#### Post date: [12.Июль.2018 05:59:27 UTC](https://meta.discourse.org/t/google-photos-images-not-downloaded/92068/8 "2018-07-12T05:59:27Z")

</div>

Oh aha maybe @vinothkannans can take a peek next week if he already worked on it before.

---

<div class="post-metadata">

### Author: ![vinothkannans](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/vinothkannans/32/86465_2.png) [@vinothkannans](https://meta.discourse.org/u/vinothkannans)
#### Post date: [12.Июль.2018 06:07:59 UTC](https://meta.discourse.org/t/google-photos-images-not-downloaded/92068/10 "2018-07-12T06:07:59Z")

</div>

We already downloading onebox images. The issue here is “Google Photos” not using file extension in the image URLs. So we are unable to fetch it from the post content. Anyway we can achieve it by adding a special case for Google. Added to my list.

> [@sam](#):
>
> Interesting … what about flickr?

Why it’s not working 🤔. It have valid image URL (`https://c1.staticflickr.com/1/18/24130109_68f93566b9_m.jpg`) inside onebox html.

---

<div class="post-metadata">

### Author: ![sam](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/sam/32/102149_2.png) [@sam](https://meta.discourse.org/u/sam)
#### Post date: [12.Июль.2018 06:46:14 UTC](https://meta.discourse.org/t/google-photos-images-not-downloaded/92068/11 "2018-07-12T06:46:14Z")

</div>

> [@vinothkannans](#):
>
> Anyway we can achieve it by adding a special case for Google.

Why do we need this though? Should we not just try to download everything that is `<img src="https://site.com/i_must_be_an_image">`, it will come back with a mime type.

---

<div class="post-metadata">

### Author: ![vinothkannans](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/vinothkannans/32/86465_2.png) [@vinothkannans](https://meta.discourse.org/u/vinothkannans)
#### Post date: [12.Июль.2018 06:56:03 UTC](https://meta.discourse.org/t/google-photos-images-not-downloaded/92068/12 "2018-07-12T06:56:03Z")

</div>

Yes, good question. We should download everything in img src. I will investigate further 👍

---

<div class="post-metadata">

### Author: ![vinothkannans](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/vinothkannans/32/86465_2.png) [@vinothkannans](https://meta.discourse.org/u/vinothkannans)
#### Post date: [31.Июль.2018 21:57:08 UTC](https://meta.discourse.org/t/google-photos-images-not-downloaded/92068/13 "2018-07-31T21:57:08Z")

</div>

I’ve fixed it here.

[https://github.com/discourse/discourse/commit/6aee22b88f61184c0fdf03c7fc16c4cfea4ed5cd](https://github.com/discourse/discourse/commit/6aee22b88f61184c0fdf03c7fc16c4cfea4ed5cd)

[https://github.com/discourse/onebox/commit/ebb4b54548d51bb63923959a16f106f787f2ad48](https://github.com/discourse/onebox/commit/ebb4b54548d51bb63923959a16f106f787f2ad48)

---

<div class="post-metadata">

### Author: ![vinothkannans](https://sea3.discourse-cdn.com/meta/user_avatar/meta.discourse.org/vinothkannans/32/86465_2.png) [@vinothkannans](https://meta.discourse.org/u/vinothkannans)
#### Post date: [06.Август.2018 12:30:09 UTC](https://meta.discourse.org/t/google-photos-images-not-downloaded/92068/14 "2018-08-06T12:30:09Z")

</div>

This topic was automatically closed after 5 days. New replies are no longer allowed.
