Hmm you’re right. There are a couple more things I need to fix when the upcoming change is disabled for this disallowed_group problem to go away:
anonymous_usersandlogged_in_usersaren’t in the group picker at all. I think it’s safe to allow these here now, then it won’t matter if you’ve addedeveryonetodisallowed_groupsif the upcoming change is turned off.- Fix
Guardian::AnonymousUser#in_any_groups?to respectanonymous_userswith the upcoming change turned off. - Add the same read time aliasing of
0 (everyone)→5 (logged_in_users)for theme settings, which we do for site settings.
I think I might also mark everyone with (legacy) in the group selector(s) while the upcoming change is still optional, and disabled.
Will prioritise these ones, and add them to my overall plan I’m working on.